For some reason pkg thinks version 26+35.1_1 is greater than 26+35.2. Not sure how this will affect upgrades or the pkg builders?

In D56125#1283796, @haraldei wrote:

For some reason pkg thinks version 26+35.1_1 is greater than 26+35.2. Not sure how this will affect upgrades or the pkg builders?

You sure? My pkg says:

$ pkg version -t 26+35.1_1 26+35.2 
<

Now fails to build like so:

ERROR: Build failed for target 'images' in configuration 'bsd-ppc64le-server-release' (exit code 2)

=== Output from failing command(s) repeated here ===
* For target hotspot_variant-server_libjvm_objs_precompiled_precompiled.hpp.pch:
In file included from /wrkdirs/usr/ports/java/openjdk26/work-jdk/openjdk-jdk-26-35-2/src/hotspot/share/precompiled/precompiled.hpp:32:
In file included from /wrkdirs/usr/ports/java/openjdk26/work-jdk/openjdk-jdk-26-35-2/src/hotspot/share/classfile/javaClasses.inline.hpp:28:
In file included from /wrkdirs/usr/ports/java/openjdk26/work-jdk/openjdk-jdk-26-35-2/src/hotspot/share/classfile/javaClasses.hpp:28:
In file included from /wrkdirs/usr/ports/java/openjdk26/work-jdk/openjdk-jdk-26-35-2/src/hotspot/share/classfile/vmClasses.hpp:30:
In file included from /wrkdirs/usr/ports/java/openjdk26/work-jdk/openjdk-jdk-26-35-2/src/hotspot/share/runtime/handles.hpp:29:
In file included from /wrkdirs/usr/ports/java/openjdk26/work-jdk/openjdk-jdk-26-35-2/src/hotspot/share/oops/oop.hpp:36:
In file included from /wrkdirs/usr/ports/java/openjdk26/work-jdk/openjdk-jdk-26-35-2/src/hotspot/share/runtime/atomicAccess.hpp:859:
In file included from /wrkdirs/usr/ports/java/openjdk26/work-jdk/openjdk-jdk-26-35-2/src/hotspot/os_cpu/bsd_ppc/atomicAccess_bsd_ppc.hpp:27:
In file included from /wrkdirs/usr/ports/java/openjdk26/work-jdk/openjdk-jdk-26-35-2/src/hotspot/cpu/ppc/atomicAccess_ppc.hpp:33:
/wrkdirs/usr/ports/java/openjdk26/work-jdk/openjdk-jdk-26-35-2/src/hotspot/cpu/ppc/orderAccess_ppc.hpp:70:28: error: redefinition of 'loadload'
   70 | inline void   OrderAccess::loadload()   { inlasm_lwsync(); }
      |                            ^
/wrkdirs/usr/ports/java/openjdk26/work-jdk/openjdk-jdk-26-35-2/src/hotspot/os_cpu/bsd_ppc/orderAccess_bsd_ppc.hpp:72:28: note: previous definition is here
   72 | inline void   OrderAccess::loadload()   { inlasm_lwsync(); }
      |                            ^
   ... (rest of output omitted)

* All command lines available in /wrkdirs/usr/ports/java/openjdk26/work-jdk/openjdk-jdk-26-35-2/build/bsd-ppc64le-server-release/make-support/failure-logs.
=== End of repeated output ===

In D56125#1283797, @fuz wrote:

In D56125#1283796, @haraldei wrote:

For some reason pkg thinks version 26+35.1_1 is greater than 26+35.2. Not sure how this will affect upgrades or the pkg builders?

You sure? My pkg says:

$ pkg version -t 26+35.1_1 26+35.2 
<

When I try to install it, I get the following:

stigmata% sudo pkg add work-jre/pkg/openjdk26-jre-26+35.2.pkg
Installing openjdk26-jre-26+35.2...
the most recent version of openjdk26-jre-26+35.1_1 is already installed

In D56125#1283835, @fuz wrote:

Now fails to build like so:

ERROR: Build failed for target 'images' in configuration 'bsd-ppc64le-server-release' (exit code 2)

=== Output from failing command(s) repeated here ===
* For target hotspot_variant-server_libjvm_objs_precompiled_precompiled.hpp.pch:
In file included from /wrkdirs/usr/ports/java/openjdk26/work-jdk/openjdk-jdk-26-35-2/src/hotspot/share/precompiled/precompiled.hpp:32:
In file included from /wrkdirs/usr/ports/java/openjdk26/work-jdk/openjdk-jdk-26-35-2/src/hotspot/share/classfile/javaClasses.inline.hpp:28:
In file included from /wrkdirs/usr/ports/java/openjdk26/work-jdk/openjdk-jdk-26-35-2/src/hotspot/share/classfile/javaClasses.hpp:28:
In file included from /wrkdirs/usr/ports/java/openjdk26/work-jdk/openjdk-jdk-26-35-2/src/hotspot/share/classfile/vmClasses.hpp:30:
In file included from /wrkdirs/usr/ports/java/openjdk26/work-jdk/openjdk-jdk-26-35-2/src/hotspot/share/runtime/handles.hpp:29:
In file included from /wrkdirs/usr/ports/java/openjdk26/work-jdk/openjdk-jdk-26-35-2/src/hotspot/share/oops/oop.hpp:36:
In file included from /wrkdirs/usr/ports/java/openjdk26/work-jdk/openjdk-jdk-26-35-2/src/hotspot/share/runtime/atomicAccess.hpp:859:
In file included from /wrkdirs/usr/ports/java/openjdk26/work-jdk/openjdk-jdk-26-35-2/src/hotspot/os_cpu/bsd_ppc/atomicAccess_bsd_ppc.hpp:27:
In file included from /wrkdirs/usr/ports/java/openjdk26/work-jdk/openjdk-jdk-26-35-2/src/hotspot/cpu/ppc/atomicAccess_ppc.hpp:33:
/wrkdirs/usr/ports/java/openjdk26/work-jdk/openjdk-jdk-26-35-2/src/hotspot/cpu/ppc/orderAccess_ppc.hpp:70:28: error: redefinition of 'loadload'
   70 | inline void   OrderAccess::loadload()   { inlasm_lwsync(); }
      |                            ^
/wrkdirs/usr/ports/java/openjdk26/work-jdk/openjdk-jdk-26-35-2/src/hotspot/os_cpu/bsd_ppc/orderAccess_bsd_ppc.hpp:72:28: note: previous definition is here
   72 | inline void   OrderAccess::loadload()   { inlasm_lwsync(); }
      |                            ^
   ... (rest of output omitted)

* All command lines available in /wrkdirs/usr/ports/java/openjdk26/work-jdk/openjdk-jdk-26-35-2/build/bsd-ppc64le-server-release/make-support/failure-logs.
=== End of repeated output ===

Hm, thanks! I'll have a look at it.

Damn, I forgot about this review. But fixing those compilation errors from the PR and the one reported here is only one part of the problem. Another one is that the built binary crashes (still before the package is built). I needed to sync os_bsd_ppc.cpp with os_linux_ppc.cpp to fix that. I'm not sure which single change actually fixed the crash.

In D56125#1290365, @pkubaj wrote:

Damn, I forgot about this review. But fixing those compilation errors from the PR and the one reported here is only one part of the problem. Another one is that the built binary crashes (still before the package is built). I needed to sync os_bsd_ppc.cpp with os_linux_ppc.cpp to fix that. I'm not sure which single change actually fixed the crash.

Thanks, I'll try to look into that.