Page MenuHomeFreeBSD

net/vpp: Update VPP to 26.02
Needs ReviewPublic

Authored by thj on Fri, Mar 20, 7:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 8, 3:37 AM
Unknown Object (File)
Tue, Apr 7, 11:12 PM
Unknown Object (File)
Thu, Apr 2, 2:14 PM
Unknown Object (File)
Thu, Mar 26, 10:04 PM
Unknown Object (File)
Thu, Mar 26, 9:36 PM
Unknown Object (File)
Thu, Mar 26, 2:42 PM
Unknown Object (File)
Tue, Mar 24, 9:34 AM
Unknown Object (File)
Sat, Mar 21, 4:09 PM
Subscribers

Details

Reviewers
jrm
Summary

Update to 26.02, move patches from the ports tree to a repo of mine in codeberg.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

thj requested review of this revision.Fri, Mar 20, 7:56 PM
thj created this revision.

@jrm last time you generated the plist for me, but I don't remember how you got everything picked up correctly. Can you help?

The build was failing because the cmake_install.cmake step for vpp-api/python was calling pip install to download and install some things from PyPi.

I have a fix that:

  1. patches src/vpp-api/python/CMakeLists.txt to use the already-installed system packages instead of downloading them.
  2. adds the missing dependencies.

Are you ok if I push those changes here, then you can take it from there, or do you prefer that I share them some other way?

net/vpp/Makefile
4

You can remove this now that DISTVERSION has increased.

thj retitled this revision from Update VPP to 26.02 to net/vpp: Update VPP to 26.02.Thu, Apr 2, 2:10 PM

Remove PORTREVISION
Add full context diff

net/vpp/Makefile
23

This is working, but I notice it's already quoted in Mk/Uses/shebangfix.mk: ${FIND} -E . -type f -iregex '${SHEBANG_REGEX}' -exec ${SED} -i '' ${_SHEBANG_REINPLACE_ARGS} {} +

23

I can't remember why we used ${CP}. I think we should use ${INSTALL_LIB}, or probably ${COPYTREE_SHARE} on ${WRKSRC}/${BUILD_PATH}/lib/ because we're not getting the structure quite correct this way. We're copying symlinks and what they point to, so we are getting two copies of some libraries.

With ${COPYTREE_SHARE}, we install a bit extra:

lib/vpp_api_test_plugins/*.so
lib/vpp_crypto_engines/lib/vpp_crypto_engines/*.so
lib/vpp_drivers/*.so

Any thoughts on whether we should include or exclude those?

thj marked an inline comment as done.