Page MenuHomeFreeBSD
Differential D55984

ufshci: fix bug in ufshci_req_sdb_enable
ClosedPublic
Actions

Authored by jaeyoon on Fri, Mar 20, 7:23 AM.
Tags
None
Referenced Files
F150087483: D55984.id174271.diff
Sun, Mar 29, 7:06 AM
Unknown Object (File)
Sat, Mar 28, 8:03 PM
Unknown Object (File)
Sat, Mar 28, 12:15 AM
Unknown Object (File)
Fri, Mar 27, 11:21 PM
Unknown Object (File)
Thu, Mar 26, 9:57 AM
Unknown Object (File)
Tue, Mar 24, 9:37 AM
Unknown Object (File)
Mon, Mar 23, 11:41 PM
Unknown Object (File)
Mon, Mar 23, 2:24 AM
View All 10 Files
Subscribers
None

Details

Reviewers
imp
Commits
rGc4386988baa2: ufshci: fix bug in ufshci_req_sdb_enable
Summary

When enabling the request queue, safely reset the list base address.
This was added due to a quirk in the Qualcomm UFS controller during
the process of activating it.

Sponsored by: Samsung Electronics

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 71576
Build 68459: arc lint + arc unit

Event Timeline

jaeyoon requested review of this revision.Fri, Mar 20, 7:23 AM
jaeyoon created this revision.
Harbormaster completed remote builds in B71576: Diff 173994.Fri, Mar 20, 7:23 AM
jaeyoon added a child revision: D55985: ufshci: add uic powermode parameter to sysctl.Fri, Mar 20, 7:24 AM
imp accepted this revision.Fri, Mar 20, 1:36 PM

Fine as is, but maybe a comment about why you're re-writing these addresses is in order?

This revision is now accepted and ready to land.Fri, Mar 20, 1:36 PM
jaeyoon updated this revision to Diff 174142.Mon, Mar 23, 1:21 AM

Add some comments

This revision now requires review to proceed.Mon, Mar 23, 1:21 AM
Harbormaster completed remote builds in B71654: Diff 174142.Mon, Mar 23, 1:21 AM
jaeyoon updated this revision to Diff 174144.Mon, Mar 23, 2:34 AM

Rebase

Harbormaster completed remote builds in B71656: Diff 174144.Mon, Mar 23, 2:34 AM
jaeyoon added a comment.Mon, Mar 23, 6:09 AM

Could you please approve this patch?

imp accepted this revision.Mon, Mar 23, 2:26 PM

I had approved before the rebase. Generally, that's approval is good unless you change something important. Rebasing, and minor tweaks to style or to fix a comment needn't wait on me.

This revision is now accepted and ready to land.Mon, Mar 23, 2:26 PM
jaeyoon added a comment.Tue, Mar 24, 12:08 AM
In D55984#1281824, @imp wrote:

I had approved before the rebase. Generally, that's approval is good unless you change something important. Rebasing, and minor tweaks to style or to fix a comment needn't wait on me.

Oh, I thought I had to get approval after the rebase, but I was wrong. Thank you!

Closed by commit rGc4386988baa2: ufshci: fix bug in ufshci_req_sdb_enable (authored by jaeyoon). · Explain WhyWed, Mar 25, 4:47 AM
This revision was automatically updated to reflect the committed changes.
jaeyoon added a commit: rGc4386988baa2: ufshci: fix bug in ufshci_req_sdb_enable.

Revision Contents
Changeset List

PathSize
sys/
dev/
ufshci/
30 lines

Diff 173994

View Options

sys/dev/ufshci/ufshci_req_sdb.c

Loading...