Paths

Table of Contentst

Differential D44896

libcrypto: compile all PIC objects with -DOPENSSL_PIC
ClosedPublic
Actions

Authored by ngie on Apr 21 2024, 5:45 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Dec 29 2025, 11:35 PM

	Unknown Object (File)
	Nov 27 2025, 1:35 AM

	Unknown Object (File)
	Nov 24 2025, 11:01 PM

	Unknown Object (File)
	Nov 1 2025, 7:05 PM

	Unknown Object (File)
	Oct 29 2025, 7:41 AM

	Unknown Object (File)
	Oct 25 2025, 3:53 AM

	Unknown Object (File)
	Oct 20 2025, 4:39 PM

	Unknown Object (File)
	Oct 20 2025, 4:39 PM

View All 77 Files

Subscribers

Details

Reviewers

Commits

rG14b9955e57cc: libcrypto: compile all PIC objects with -DOPENSSL_PIC

Summary

This change modifies the libcrypto PIC objects to always link with
-DOPENSSL_PIC to restore parity with the upstream build process. This
ensures that -DOPENSSL_PIC is used whenever building the auxiliary
shared objects, e.g., the fips provider, the legacy provider, etc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 71560
Build 68443: arc lint + arc unit

Event Timeline

ngie created this revision.Apr 21 2024, 5:45 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 21 2024, 5:45 PM

ngie requested review of this revision.Apr 21 2024, 5:45 PM

Harbormaster completed remote builds in B57260: Diff 137465.Apr 21 2024, 5:45 PM

Fix the change to properly append the CFLAG to PICFLAG and do it after including bsd.lib.mk to properly compile/link libcrypto.so.

Harbormaster completed remote builds in B57262: Diff 137467.Apr 21 2024, 6:37 PM

e.g., the fips provider, the legacy provider, etc.

Actually it is precisely just those two

Move the definition to secure/lib/libcrypto/modules/Makefile.inc

This only affects modules - nothing else.

Harbormaster completed remote builds in B71560: Diff 173963.Thu, Mar 19, 11:59 PM

emaste accepted this revision.Fri, Mar 20, 12:44 AM

This revision is now accepted and ready to land.Fri, Mar 20, 12:44 AM

Closed by commit rG14b9955e57cc: libcrypto: compile all PIC objects with -DOPENSSL_PIC (authored by ngie). · Explain WhyFri, Mar 20, 12:52 AM

This revision was automatically updated to reflect the committed changes.

ngie added a commit: rG14b9955e57cc: libcrypto: compile all PIC objects with -DOPENSSL_PIC.

Revision Contents
Changeset List

Path

Size

secure/

lib/

libcrypto/

modules/

2 lines

Diff 173963

secure/lib/libcrypto/modules/Makefile.inc

Loading...