system(3): Address test robustness issue
ClosedPublic
Actions

Authored by des on Sat, Mar 7, 6:17 PM.

Details

Reviewers

kevans

Group Reviewers

Klara

Commits

rGc4c375354287: system(3): Address test robustness issue
rG48368f702423: system(3): Address test robustness issue

Summary

Don't assume that SIGINT and SIGQUIT are set to SIG_DFL at the start
of the test. Instead, retrieve their current dispositions and verify
that they are restored at the end of the test.

MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 71298
Build 68181: arc lint + arc unit

Event Timeline

des created this revision.Sat, Mar 7, 6:17 PM

Herald added a subscriber: imp. · View Herald TranscriptSat, Mar 7, 6:17 PM

des requested review of this revision.Sat, Mar 7, 6:17 PM

Harbormaster completed remote builds in B71243: Diff 173309.Sat, Mar 7, 6:17 PM

kevans added a subscriber: kevans.Mon, Mar 9, 2:34 PM

kevans added inline comments.

lib/libc/tests/stdlib/system_test.c
134	Two points: 1.) I think we want another set of tests, then, and be explicit about it: one that explicitly sets them to `SIG_DFL` and one that ignores them, so that we can be sure no matter the test runner's configuration that it's restoring rather than that the disposition upon return was accidentally right 2.) We should probably use `sigaction()` for recording existing disposition if we suspect atf might have setup a handler to avoid breaking it