df: Make warning failures fatal
Needs ReviewPublic
Actions

Authored by jlduran on Mar 1 2026, 9:51 PM.

Details

Reviewers

Summary

Replace xo_warn() and xo_warnx() calls with xo_err() and xo_errx()
throughout the df command to ensure consistent error reporting and
proper exit codes when memory allocation or a system call fails.
This improves the reliability and behavior of the command in error
conditions.

Suggested by: des

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

Note that we want to keep the current behavior in makenetvfslist().

jlduran added a parent revision: D54457: df: Cleanup and refactor.Mar 1 2026, 9:54 PM

jlduran mentioned this in D54457: df: Cleanup and refactor.

In D55610#1272406, @jlduran wrote:

Note that we want to keep the current behavior in makenetvfslist().

Why?

In D55610#1272421, @des wrote:

In D55610#1272406, @jlduran wrote:

Note that we want to keep the current behavior in makenetvfslist().

Why?

Actually my original statement should have been a question.
I see the code comes from a25695c3a433cd76b68427ef324efc1f109f36ed, as a result of the bug report:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=27240
It is not clear why warnx() was preferred.
I'll update shortly.

jlduran updated this revision to Diff 173019.Mar 2 2026, 5:12 PM

jlduran retitled this revision from df: Make malloc() failure fatal to df: Make warning failures fatal.

jlduran edited the summary of this revision. (Show Details)

jlduran added inline comments.Mar 2 2026, 5:16 PM

bin/df/df.c
658	I'm not a fan of this chunk of code.

des added inline comments.Mar 2 2026, 5:28 PM

bin/df/df.c
658	Well then refactor it. It was written this way to avoid duplicating the cleanup, but since you are now existing on allocation failure, that problem no longer exists.