- Add WWW for source code repository.
- Static tarball is available, but not used, as GH_TUPLE is needed for bundled external libraries and 3-rd party plugins.
- GL is needed for the main application, not for the plugins only.
- Build PLUGIN_IO_QPDAL unconditionally, just like other plugins.
- Supply *.desktop with *.png files from the previous version, as upstream doesn't ship them anymore. Fix post-install accordingly.
- Fix plugin path detection actually enabling plugins autoloading.
- Improve COMMENT and pkg-descr
Details
For every {150amd64, 143amd64}:
- Successful poudriere testport
- Successful run-testing
Diff Detail
- Repository
- R11 FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 70877 Build 67760: arc lint + arc unit
Event Timeline
| graphics/cloudcompare/Makefile | ||
|---|---|---|
| 92 | You can install and replace in one go with ${SED} ... > ${STAGEDIR}... | |
| graphics/cloudcompare/files/cloudcompare.desktop | ||
| 9 | Doesn't Icon=cloudcompare work? If yes, this should be preferred, because advanced DE themes will be able to override the original icon with a themed one. | |
| graphics/cloudcompare/files/cloudcompare.png | ||
| 1 | Not really sure about committing png images into the repo. In textproc/obsidian I just put it into DISTFILES so that the icon gets downloaded during make fetch. I feel like it is a better approach. | |
| graphics/cloudcompare/pkg-descr | ||
| 9 | I don't think we need a history lesson in pkg-descr. | |
| graphics/cloudcompare/Makefile | ||
|---|---|---|
| 92 | Please, more on this: how (if) could I do it for both (or many) files in one command? I like the idea just can't get it... | |
| graphics/cloudcompare/files/cloudcompare.desktop | ||
| 9 | Yes, it does, thanks! | |
| graphics/cloudcompare/files/cloudcompare.png | ||
| 1 | I would possibly follow your advice if I could. As I have to use GH_TUPLE for bundled external libraries and plugins, I can't use MASTER_SITES at the same time. May be, I just don't know how to do it (properly, and at all). | |
| graphics/cloudcompare/pkg-descr | ||
| 9 | I tried to reword the sentences to your advice. | |
| graphics/cloudcompare/Makefile | ||
|---|---|---|
| 92 | You'll need a make or a shell loop to do this for multiple files, so feel free to leave it as is if you don't like loops. | |
| graphics/cloudcompare/files/cloudcompare.png | ||
| 1 | MASTER_SITES with a non-default category should work even in presence of USE_GITHUB: MASTER_SITES= https://../:icon DISTFILES= cloudcompare.png:icon EXTRACT_ONLY= | |
| graphics/cloudcompare/files/cloudcompare.png | ||
|---|---|---|
| 1 | Sorry, but I really can't make it work following your advice: the other DISTFILES - plugins from GH_TUPLE - are failing to unpack properly. | |
| graphics/cloudcompare/files/cloudcompare.png | ||
|---|---|---|
| 1 | Could you, please, allow me to just commit these 2 PNGs to the tree? | |
| graphics/cloudcompare/files/cloudcompare.png | ||
|---|---|---|
| 1 | I'm not in a position to allow or deny you anything. I just tried to provide some useful input, but if it isn't really applicable to your case - then of course do it your way. | |
| graphics/cloudcompare/files/cloudcompare.png | ||
|---|---|---|
| 1 | Thank you! :) | |
It is not recommended to put binaries into the ports repository.
Can you show direct links to *.png files?
I'll try to fix this.
| graphics/cloudcompare/Makefile | ||
|---|---|---|
| 88 | Use ${DESKTOPDIR} instead of ${PREFIX}/share/applications. | |
Sure, I can:
https://github.com/CloudCompare/CloudCompare/tree/v2.12.4/snap/gui
https://github.com/CloudCompare/CloudCompare/blob/v2.12.4/snap/gui/ccViewer.png
https://github.com/CloudCompare/CloudCompare/blob/v2.12.4/snap/gui/cloudcompare.png
Hope you could do it, so I could learn from you. Even if not, I'll be glad you tried to help me :)
| graphics/cloudcompare/Makefile | ||
|---|---|---|
| 88 | Thanks! Done. :) | |
Try this:
MASTER_SITES= https://raw.githubusercontent.com/${GH_ACCOUNT}/${GH_PROJECT}/refs/tags/v2.12.4/snap/gui/:icons
DISTFILES= ccViewer.png:icons cloudcompare.png:icons
DIST_SUBDIR= ${PORTNAME}-${DISTVERSION}
EXTRACT_ONLY= ${_DISTFILES:N*.png}Don't forget make makesum.