Page MenuHomeFreeBSD
Differential D55339

sysutils/podman: Allow setting ownership on auto-created socket
ClosedPublic
Actions

Authored by dch on Tue, Feb 17, 11:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Feb 25, 4:48 PM
Unknown Object (File)
Wed, Feb 25, 3:48 PM
Unknown Object (File)
Wed, Feb 25, 11:19 AM
Unknown Object (File)
Wed, Feb 25, 12:22 AM
Unknown Object (File)
Mon, Feb 23, 2:33 PM
Unknown Object (File)
Sun, Feb 22, 8:39 PM
Unknown Object (File)
Fri, Feb 20, 1:23 AM
Unknown Object (File)
Wed, Feb 18, 2:05 PM
View All 10 Files
Subscribers
None

Details

Reviewers
dfr
arrowd
Commits
R11:2c53428ae117: sysutils/podman: Allow setting ownership on auto-created socket
Summary

The podman daemon auto-creates a socket on startup, along with parent
directory, and
is always run as root. It is often useful to have another proxy like
haproxy or nginx
provide more sophisticed security, and these daemons do not need root
privileges.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 70750
Build 67633: arc lint + arc unit

Event Timeline

dch requested review of this revision.Tue, Feb 17, 11:29 PM
dch created this revision.
Harbormaster completed remote builds in B70739: Diff 172109.Tue, Feb 17, 11:29 PM
dch added reviewers: dfr, arrowd.Tue, Feb 17, 11:30 PM

NB I would eventually like to fix this upstream too, but I have need of this functionality already.

arrowd added a comment.Wed, Feb 18, 5:59 AM

After applying this patch to /usr/local/etc/rc.d/podman_service I can now run Podman Desktop without the need to do chmod on the socket. Yay!

dfr accepted this revision.Wed, Feb 18, 10:50 AM

Looks good, apart from a tiny style nit.

sysutils/podman/files/podman.in
42–45

Change indentation to line up with other functions below

This revision is now accepted and ready to land.Wed, Feb 18, 10:50 AM
dch updated this revision to Diff 172152.Wed, Feb 18, 2:43 PM

update after go port bump, reflow commit text

This revision now requires review to proceed.Wed, Feb 18, 2:43 PM
Harbormaster completed remote builds in B70750: Diff 172152.Wed, Feb 18, 2:43 PM
dfr added a comment.Wed, Feb 18, 4:50 PM

Still looks good (apart from the indentation mismatch for podman_prestart)

arrowd added a comment.Wed, Feb 18, 6:26 PM

What about the podman_service rc script? I guess it should get the same change?

This revision was not accepted when it landed; it landed in state Needs Review.Sun, Feb 22, 7:48 PM
Closed by commit R11:2c53428ae117: sysutils/podman: Allow setting ownership on auto-created socket (authored by dch). · Explain Why
This revision was automatically updated to reflect the committed changes.
dch added a commit: R11:2c53428ae117: sysutils/podman: Allow setting ownership on auto-created socket.
dch added a reverting change: R11:0882ac8e21b3: sysutils/podman: Revert "Allow setting ownership on auto-created socket".Mon, Feb 23, 11:40 AM

Revision Contents
Changeset List

PathSize
sysutils/
podman/
2 lines
files/
32 lines

Diff 172152

View Options

sysutils/podman/Makefile

Loading...
View Options

sysutils/podman/files/podman.in

Loading...