Differential D55303

ee: add unicode support
ClosedPublic
Actions

Authored by bapt on Mon, Feb 16, 11:40 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Mar 1, 3:35 PM

	Unknown Object (File)
	Sun, Mar 1, 10:00 AM

	Unknown Object (File)
	Fri, Feb 27, 11:26 PM

	Unknown Object (File)
	Tue, Feb 24, 5:21 AM

	Unknown Object (File)
	Tue, Feb 24, 3:04 AM

	Unknown Object (File)
	Mon, Feb 23, 2:35 PM

	Unknown Object (File)
	Mon, Feb 23, 3:42 AM

	Unknown Object (File)
	Sat, Feb 21, 4:13 PM

View All 50 Files

Subscribers

yklaxds_gmail.com

zarychtam_plan-b.pwste.edu.pl

Details

Reviewers: None
Commits: rG62fba0054d9e: ee: add unicode support

Summary

Add native support for unicode everywhere.
Remove Big5 specific code (and the menu entry)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 70692
Build 67575: arc lint + arc unit

Event Timeline

bapt created this revision.Mon, Feb 16, 11:40 AM

Herald added a subscriber: imp. · View Herald TranscriptMon, Feb 16, 11:40 AM

bapt requested review of this revision.Mon, Feb 16, 11:40 AM

Harbormaster completed remote builds in B70692: Diff 171964.Mon, Feb 16, 11:40 AM

michaelo added a subscriber: michaelo.Mon, Feb 16, 12:23 PM

michaelo added inline comments.

contrib/ee/ee.c
676	Please call me stupid, but why is the exit code zero if the status is an error?

Works fine for me. I tried to insert a lot of different Unicode characters, including smileys and other weird symbols, and everything seems to be supported.
Please push it and do the MFC, it will be highly appreciated by the FreeBSD users, especially those newbies and Gen-Z who don't know how to use vi editor.

yklaxds_gmail.com added a subscriber: yklaxds_gmail.com.Mon, Feb 16, 1:32 PM

bapt added inline comments.Tue, Feb 17, 8:26 AM

contrib/ee/ee.c
676	wget_wch (and wgetch befor) will return ERR if the undersneath terminal is closed (like network failure on a ssh session) I bet upstream has decided that this is not an editor error, but the user lost its network connection, so a "normal" exit is appropriate. I understand this might be debattable, but this is not the scope of this change. That said I can probably readd the comment

michaelo added inline comments.Tue, Feb 17, 8:27 AM

contrib/ee/ee.c
676	That makes sense. I line of explanation would clarify a lot.

This revision was not accepted when it landed; it landed in state Needs Review.Tue, Feb 17, 11:50 AM

Closed by commit rG62fba0054d9e: ee: add unicode support (authored by bapt). · Explain Why

This revision was automatically updated to reflect the committed changes.

bapt added a commit: rG62fba0054d9e: ee: add unicode support.

Revision Contents
Changeset List

Path

Size

contrib/

ee/

633 lines

Diff 171964

contrib/ee/ee.c

Loading...