Page MenuHomeFreeBSD

Make pure-ftpd flags configurable in /etc/rc.conf
ClosedPublic

Authored by asomers on Jun 1 2016, 4:49 PM.
Tags
None
Referenced Files
F80157872: D6676.id18480.diff
Thu, Mar 28, 4:49 PM
Unknown Object (File)
Tue, Mar 5, 12:43 AM
Unknown Object (File)
Mon, Mar 4, 6:09 AM
Unknown Object (File)
Mon, Mar 4, 6:09 AM
Unknown Object (File)
Mon, Mar 4, 5:57 AM
Unknown Object (File)
Feb 17 2024, 2:56 PM
Unknown Object (File)
Jan 23 2024, 11:47 AM
Unknown Object (File)
Jan 23 2024, 12:42 AM
Subscribers

Details

Summary

Recognize a "pureftpd_flags" variable in pure-ftpd's rc script. Pretty much
anything that can be placed in /usr/local/etc/pure-ftpd.conf can be placed in
this variable instead.

ftp/pure-ftpd/Makefile
Bump PORTREVISION

ftp/pure-ftpd/files/pure-ftpd.in
Handle pureftpd_flags. It needs special handling because, unlike most
daemons, pure-config.pl takes its mandatory argument first and its
optional flags last.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 4071
Build 4114: arc lint + arc unit

Event Timeline

asomers retitled this revision from to Make pure-ftpd flags configurable in /etc/rc.conf.
asomers updated this object.
asomers edited the test plan for this revision. (Show Details)
asomers added a reviewer: sunpoet.
asomers added a subscriber: brd.
ftp/pure-ftpd/files/pure-ftpd.in
52

What is the point of flags here? Maybe that should be pureftpd_flags?

ftp/pure-ftpd/files/pure-ftpd.in
52

"flags" is understood by /etc/rc.subr in run_rc_command. Long story short, run_rc_command will run

$command $rc_flags $command_args

which expands to

pure-config.pl $flags $pureftpd_flags

which expands to

pure-config.pl ${pureftpd_config} -g{$pidfile} <whatever>

I plan to commit this tomorrow if I don't hear from anyone.

This revision was automatically updated to reflect the committed changes.