mixer/tests: use require.kmods property instead of ad-hoc checks
ClosedPublic
Actions

Authored by siva on Tue, Feb 10, 3:07 PM.

Details

Reviewers

christos
lwhsu

Commits

rG3bd7deffdda7: mixer/tests: use require.kmods property instead of ad-hoc checks
rG5fa297f4bcd2: mixer/tests: use require.kmods property instead of ad-hoc checks

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 70581
Build 67464: arc lint + arc unit

Event Timeline

siva created this revision.Tue, Feb 10, 3:07 PM

Herald added a subscriber: imp. · View Herald TranscriptTue, Feb 10, 3:07 PM

siva requested review of this revision.Tue, Feb 10, 3:07 PM

Harbormaster completed remote builds in B70581: Diff 171649.Tue, Feb 10, 3:07 PM

lwhsu accepted this revision.Tue, Feb 10, 7:40 PM

This revision is now accepted and ready to land.Tue, Feb 10, 7:40 PM

christos added inline comments.Tue, Feb 10, 10:05 PM

usr.sbin/mixer/tests/Makefile
5	Isn't it cleaner for this to be inside the test script?

siva added inline comments.Tue, Feb 10, 10:22 PM

usr.sbin/mixer/tests/Makefile
5	It's a bit simpler to add it here just to avoid so much duplication, because there are exactly 5 tests and all of them need this. Currently, it is equivalent.

christos accepted this revision.Tue, Feb 10, 11:02 PM

Closed by commit rG5fa297f4bcd2: mixer/tests: use require.kmods property instead of ad-hoc checks (authored by siva). · Explain WhyThu, Feb 12, 3:04 PM

This revision was automatically updated to reflect the committed changes.

siva added a commit: rG5fa297f4bcd2: mixer/tests: use require.kmods property instead of ad-hoc checks.

christos added a commit: rG3bd7deffdda7: mixer/tests: use require.kmods property instead of ad-hoc checks.Tue, Feb 17, 12:52 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

mixer/

tests/

Makefile

3 lines

mixer_test.sh

12 lines

Diff 171649

View Options

usr.sbin/mixer/tests/Makefile