Don't call setgrent() in an unportable way.
ClosedPublic
Actions

Authored by ed on May 31 2016, 1:44 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Nov 11, 2:32 AM

	Unknown Object (File)
	Mon, Nov 10, 11:41 PM

	Unknown Object (File)
	Mon, Nov 10, 8:45 PM

	Unknown Object (File)
	Mon, Nov 10, 8:45 PM

	Unknown Object (File)
	Mon, Nov 10, 8:45 PM

	Unknown Object (File)
	Mon, Nov 10, 5:09 PM

	Unknown Object (File)
	Thu, Oct 30, 12:19 AM

	Unknown Object (File)
	Sun, Oct 19, 1:19 AM

View All 91 Files

Subscribers

imp

Details

Reviewers

oshogbo

Commits

rS301167: Don't call setgrent() in an unportable way.

Summary

For FreeBSD 12, I'm considering updating setgrent() to have a function
prototype that conforms to POSIX. FreeBSD seems to be the only operating
system that lets setgrent() return an integer. It's also inconsistent
with setpwent().

It looks like our libcasper depends on setgrent() returning an integer.
Get rid of that.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4048
Build 4091: arc lint + arc unit

Event Timeline

ed updated this revision to Diff 17149.May 31 2016, 1:44 PM

ed retitled this revision from to Don't call setgrent() in an unportable way..

ed updated this object.

ed edited the test plan for this revision. (Show Details)

ed added a reviewer: oshogbo.

Herald added a subscriber: imp. · View Herald TranscriptMay 31 2016, 1:44 PM

Looks good for me.

This revision is now accepted and ready to land.Jun 1 2016, 7:55 PM

Closed by commit rS301167: Don't call setgrent() in an unportable way. (authored by ed). · Explain WhyJun 1 2016, 8:45 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

lib/

libcasper/

services/

cap_grp/

cap_grp.c

4 lines

Diff 17149

View Options

lib/libcasper/services/cap_grp/cap_grp.c

Don't call setgrent() in an unportable way.ClosedPublicActions