Page MenuHomeFreeBSD
Differential D54919

cpucontrol: Be more strict with input validation
ClosedPublic
Actions

Authored by markj on Tue, Jan 27, 9:23 PM.
Tags
None
Referenced Files
F145674058: D54919.id170618.diff
Sun, Feb 22, 11:32 PM
Unknown Object (File)
Mon, Feb 16, 7:01 PM
Unknown Object (File)
Mon, Feb 16, 7:01 PM
Unknown Object (File)
Sun, Feb 15, 12:45 PM
Unknown Object (File)
Thu, Feb 12, 5:14 PM
Unknown Object (File)
Wed, Feb 11, 10:36 PM
Unknown Object (File)
Wed, Feb 11, 4:43 AM
Unknown Object (File)
Tue, Feb 10, 10:35 AM
View All 21 Files
Subscribers
imp

Details

Reviewers
kib
Commits
rG93fe6d43f8ed: cpucontrol: Be more strict with input validation
rG59bbb62b6078: cpucontrol: Be more strict with input validation
Summary

Avoid truncating 32-bit values. This would have saved me a bit of time
when I was looking at a cpuid leaf on my system and typed 0x80000001f
instead of 0x8000001f.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 70174
Build 67057: arc lint + arc unit

Event Timeline

markj created this revision.Tue, Jan 27, 9:23 PM
Herald added a subscriber: imp. · View Herald TranscriptTue, Jan 27, 9:23 PM
Harbormaster completed remote builds in B70172: Diff 170614.Tue, Jan 27, 9:23 PM
markj requested review of this revision.Tue, Jan 27, 9:23 PM
kib added inline comments.Tue, Jan 27, 9:41 PM
usr.sbin/cpucontrol/cpucontrol.c
123

Why not strtoumax() then?

126

I do not think that usage() is required there, user does know what she did, but mis-typed the input.

markj updated this revision to Diff 170618.Tue, Jan 27, 11:01 PM
markj marked 2 inline comments as done.

Handle kib's comments.

Harbormaster completed remote builds in B70174: Diff 170618.Tue, Jan 27, 11:01 PM
markj added inline comments.Tue, Jan 27, 11:01 PM
usr.sbin/cpucontrol/cpucontrol.c
126

Ok, I just copied the prevailing pattern.

kib accepted this revision.Tue, Jan 27, 11:22 PM
This revision is now accepted and ready to land.Tue, Jan 27, 11:22 PM
Closed by commit rG59bbb62b6078: cpucontrol: Be more strict with input validation (authored by markj). · Explain WhyWed, Jan 28, 5:48 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG59bbb62b6078: cpucontrol: Be more strict with input validation.
markj added a commit: rG93fe6d43f8ed: cpucontrol: Be more strict with input validation.Mon, Feb 16, 3:44 PM

Revision Contents
Changeset List

PathSize
usr.sbin/
cpucontrol/
25 lines

Diff 170618

View Options

usr.sbin/cpucontrol/cpucontrol.c

Loading...