Differential D54694

iwlwifi/rtw89: improve module Makefile dependency on ACPI
ClosedPublic
Actions

Authored by bz on Tue, Jan 13, 9:18 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Jan 15, 8:30 AM

	Unknown Object (File)
	Thu, Jan 15, 5:49 AM

	Unknown Object (File)
	Wed, Jan 14, 8:02 AM

	Unknown Object (File)
	Wed, Jan 14, 5:09 AM

	Unknown Object (File)
	Wed, Jan 14, 4:27 AM

	Unknown Object (File)
	Wed, Jan 14, 3:55 AM

	Unknown Object (File)
	Wed, Jan 14, 3:54 AM

	Unknown Object (File)
	Wed, Jan 14, 3:44 AM

View All 10 Files

Subscribers

Details

Reviewers

Commits

rG4a56313c73eb: iwlwifi/rtw89: improve module Makefile dependency on ACPI
rGf5a77dc8f8df: iwlwifi/rtw89: improve module Makefile dependency on ACPI

Summary

In order to compile iwlwiif(4) and rtw89(4) on RISC-V [1] make the
currently manually tracked ACPI support option automatic based on
DEV_ACPI.
rtw89(4) is missing proper CONFIG_ACPI checks in the driver (or the
mandatory dependency on ACPI) even upstream it seems. We just added
that check to the modules/Makefile until this is fixed.

[1] https://mail-archive.freebsd.org/cgi/getmsg.cgi?fetch=5947+0+archive/2026/freebsd-wireless/20260112.freebsd-wireless

Sponosred by: The FreeBSD Foundation
MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bz created this revision.Tue, Jan 13, 9:18 PM

Herald added a subscriber: imp. · View Herald TranscriptTue, Jan 13, 9:18 PM

bz requested review of this revision.Tue, Jan 13, 9:18 PM

Harbormaster completed remote builds in B69862: Diff 169577.Wed, Jan 14, 12:50 AM

bz added a parent revision: D54693: modules: factor out LinuxKPI based wireless drivers and add RISC-V.Wed, Jan 14, 6:39 AM

bz added a parent revision: D54689: net/wifi-firmware-kmod: enable riscv64 for wireless firmware.

emaste accepted this revision.Wed, Jan 14, 4:10 PM

This revision is now accepted and ready to land.Wed, Jan 14, 4:10 PM

Closed by commit rGf5a77dc8f8df: iwlwifi/rtw89: improve module Makefile dependency on ACPI (authored by bz). · Explain WhyWed, Jan 14, 6:10 PM

This revision was automatically updated to reflect the committed changes.

bz added a commit: rGf5a77dc8f8df: iwlwifi/rtw89: improve module Makefile dependency on ACPI.

bz added a commit: rG4a56313c73eb: iwlwifi/rtw89: improve module Makefile dependency on ACPI.Sat, Jan 17, 1:10 PM

Revision Contents
Changeset List

Path

Size

sys/

modules/

iwlwifi/

7 lines

rtw89/

13 lines

Diff 169728

sys/modules/iwlwifi/Makefile

Loading...

sys/modules/rtw89/Makefile

Loading...