speaker, clock: Replace Giant lock with fine-grained locking
Needs ReviewPublic
Actions

Authored by guest-seuros on Sat, Jan 10, 10:34 AM.

Tags

None

Referenced Files

	F142854085: D54634.diff
	Sat, Jan 24, 4:59 AM

	Unknown Object (File)
	Tue, Jan 20, 4:13 AM

	Unknown Object (File)
	Tue, Jan 20, 1:14 AM

	Unknown Object (File)
	Sun, Jan 18, 3:29 AM

	Unknown Object (File)
	Sun, Jan 18, 12:46 AM

	Unknown Object (File)
	Sat, Jan 17, 11:08 AM

	Unknown Object (File)
	Sun, Jan 11, 1:13 AM

	Unknown Object (File)
	Sat, Jan 10, 11:37 PM

View All 9 Files

Subscribers

imp

This revision needs review, but there are no reviewers specified.

Details

Reviewers: None

Summary

Add sx lock to the speaker driver to protect spkr_active and spkr_inbuf,
removing the D_NEEDGIANT flag. Add mtx_lock_spin protection for timer2_state
in clock.c timer_spkr_acquire/release functions.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 69782
Build 66665: arc lint + arc unit

Event Timeline

guest-seuros created this revision.Sat, Jan 10, 10:34 AM

Herald added a subscriber: imp. · View Herald TranscriptSat, Jan 10, 10:34 AM

guest-seuros requested review of this revision.Sat, Jan 10, 10:34 AM

Harbormaster completed remote builds in B69782: Diff 169446.Sat, Jan 10, 10:34 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

speaker/

spkr.c

73 lines

x86/

isa/

clock.c

12 lines

Diff 169446

View Options

sys/dev/speaker/spkr.c