Page MenuHomeFreeBSD
Differential D54619

Uses/cargo: remove deprecated '-C ar=' from RUSTFLAGS
Needs ReviewPublic
Actions

Authored by siva on Fri, Jan 9, 3:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jan 26, 4:26 PM
Unknown Object (File)
Mon, Jan 26, 1:17 PM
Unknown Object (File)
Sat, Jan 24, 4:36 AM
Restricted File
Thu, Jan 22, 9:51 PM
Unknown Object (File)
Wed, Jan 21, 6:10 AM
Unknown Object (File)
Tue, Jan 20, 10:16 AM
Unknown Object (File)
Sun, Jan 18, 10:15 PM
Unknown Object (File)
Sat, Jan 17, 12:52 PM
View All 19 Files
Subscribers
michaelo
mikael

Details

Reviewers
None
Group Reviewers
rust
Summary

This removes a lot of redundant deprecation warning reports.

See https://doc.rust-lang.org/rustc/codegen-options/index.html#ar

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

siva requested review of this revision.Fri, Jan 9, 3:48 PM
siva created this revision.
michaelo added a subscriber: michaelo.Fri, Jan 9, 10:37 PM

Can you investigate when this has been dropped?

michaelo added a comment.Fri, Jan 9, 10:44 PM

https://github.com/rust-lang/rust/pull/26926

michaelo added a comment.Sat, Jan 10, 10:10 AM

Maybe you should check these as well:

$ grep -r --include=Makefile ar= .
./astro/gpsd/Makefile:GEOSTAR_MAKE_ARGS_OFF=            geostar=no
./audio/cardinal/Makefile:BINARY_ALIAS= gcc-ar=ar \
./databases/leofs/Makefile:     leo-project/bear=0.8.2-for-leofs:bear \
./devel/electron37/Makefile:                    ar=${LOCALBASE}/bin/llvm-ar${LLVM_DEFAULT} \
./devel/electron38/Makefile:                    ar=${LOCALBASE}/bin/llvm-ar${LLVM_DEFAULT} \
./devel/electron39/Makefile:                    ar=${LOCALBASE}/bin/llvm-ar${LLVM_DEFAULT} \
./editors/libreoffice/Makefile:                 --with-commons-codec-jar=${JAVAJARDIR}/commons-codec.jar \
./editors/libreoffice/Makefile:                 --with-commons-httpclient-jar=${JAVAJARDIR}/commons-httpclient.jar \
./editors/libreoffice/Makefile:                 --with-commons-lang-jar=${JAVAJARDIR}/commons-lang3.jar \
./editors/libreoffice/Makefile:                 --with-commons-logging-jar=${JAVAJARDIR}/commons-logging.jar \
./editors/libreoffice/Makefile:         --with-external-tar=${DISTDIR}/${DIST_SUBDIR} \
./editors/openoffice-4/Makefile:        commons-codec-jar=${JAVALIBDIR}/commons-codec.jar              \
./editors/openoffice-4/Makefile:        commons-httpclient-jar=${JAVALIBDIR}/commons-httpclient.jar    \
./editors/openoffice-4/Makefile:        commons-logging-jar=${JAVALIBDIR}/commons-logging.jar
./editors/openoffice-4/Makefile:                        --with-commons-lang-jar=${JAVALIBDIR}/commons-lang.jar \
./editors/openoffice-4/Makefile:                        --with-beanshell-jar=${JAVALIBDIR}/bsh.jar     \
./editors/openoffice-4/Makefile:                        --with-lucene-core-jar=${JAVALIBDIR}/lucene-core-3.6.2.jar \
./editors/openoffice-4/Makefile:                        --with-lucene-analyzers-jar=${JAVALIBDIR}/lucene-analyzers-3.6.2.jar \
./editors/openoffice-devel/Makefile:    commons-codec-jar=${JAVALIBDIR}/commons-codec.jar              \
./editors/openoffice-devel/Makefile:    commons-httpclient-jar=${JAVALIBDIR}/commons-httpclient.jar
./editors/openoffice-devel/Makefile:CONFIGURE_ARGS+=    --with-commons-logging-jar=${JAVALIBDIR}/commons-logging.jar
./editors/openoffice-devel/Makefile:                    --with-commons-lang-jar=${JAVALIBDIR}/commons-lang3.jar \
./editors/openoffice-devel/Makefile:                    --with-beanshell-jar=${JAVALIBDIR}/bsh.jar     \
./editors/openoffice-devel/Makefile:                    --with-lucene-core-jar=${JAVALIBDIR}/lucene-core-3.6.2.jar \
./editors/openoffice-devel/Makefile:                    --with-lucene-analyzers-jar=${JAVALIBDIR}/lucene-analyzers-3.6.2.jar \
./filesystems/rar2fs/Makefile:          --with-unrar=`${MAKE} -C ${PORTSDIR}/${LIBUNRAR_PORT} -VWRKSRC` \
./graphics/frogr/Makefile:MESON_ARGS=   -Denable-header-bar=true
./graphics/libskiasharp/Makefile:               ar=${LOCALBASE}/bin/ar
./graphics/rawtherapee/Makefile:BINARY_ALIAS+=  ar=${AR} ranlib=${RANLIB}
./graphics/skia/Makefile:               ar=llvm-ar
./java/apache-commons-beanutils/Makefile:MAKE_ARGS+=    -Dcommons-collections.jar=${JAVALIBDIR}/commons-collections.jar \
./java/apache-commons-beanutils/Makefile:               -Dcommons-logging.jar=${JAVALIBDIR}/commons-logging.jar
./java/javahelp/Makefile:MAKE_ARGS=     -Djsp-jar=${TOMCAT_jsp} \
./java/javahelp/Makefile:               -Dfile.reference.jsp-api.jar=${TOMCAT_jsp} \
./java/javahelp/Makefile:               -Dservlet-jar=${TOMCAT_servlet} \
./java/javahelp/Makefile:               -Dfile.reference.servlet-api.jar=${TOMCAT_servlet} \
./java/javamail/Makefile:MAKE_ARGS+=    -Dactivation.jar=${DISTDIR}/jakarta.activation.jar
./java/sigar/Makefile:          -Djunit.jar="${JAVALIBDIR}/junit.jar" test
./lang/rust/Makefile:   @${ECHO_CMD} 'ar="${AR}"' >> ${WRKSRC}/config.toml
./lang/rust188/Makefile:        @${ECHO_CMD} 'ar="${AR}"' >> ${WRKSRC}/config.toml
./math/octave-forge-rtree/Makefile:BINARY_ALIAS=        tar=gtar
./math/polymake/Makefile:SINGULAR_CONFIGURE_ON= --with-singular=${LOCALBASE}
./misc/amanda-server/Makefile:          --with-gnutar=${LOCALBASE}/bin/gtar
./net-im/ejabberd/Makefile:CONFIGURE_ARGS+=--localstatedir=/var --libdir=${PREFIX}/${EJABBERD_LIBDIR} --with-rebar=rebar
./security/courier-authlib/Makefile:            --with-authdaemonvar=${AUTHDAEMONVAR} \
./sysutils/edk2/Makefile:               ar=${AR} \
./sysutils/edk2/Makefile:               gcc-ar=${LOCALBASE}/bin/${CC:S/gcc/&-ar/} \
./www/chromium/Makefile:                        ar=${LOCALBASE}/bin/llvm-ar${LLVM_DEFAULT} \
./www/iridium/Makefile:                 ar=${LOCALBASE}/bin/llvm-ar${LLVM_DEFAULT} \
./www/onlyoffice-documentserver/Makefile:BINARY_ALIAS+= ar=${LOCALBASE}/bin/llvm-ar${LLVM_DEFAULT} \
./www/ungoogled-chromium/Makefile:                      ar=${LOCALBASE}/bin/llvm-ar${LLVM_DEFAULT
siva added a comment.Sat, Jan 10, 4:06 PM

Yes, I can look into each of those ports in a future review. This review is narrowly scoped to just RUSTFLAGS, can we get this in first?

Also, a lot of those are false positives due to 'jar=' matching on Java ports as well. I'll look into it properly soon and post a review fixing the ones that need fixing.

michaelo added a subscriber: mikael.Wed, Jan 21, 8:41 PM

@mikael Any objections?

mikael added a comment.Thu, Jan 22, 8:15 AM

How do I even quote a message with phab?

What are these "redundant deprecation warning reports" ?

siva added a comment.Thu, Jan 22, 9:51 PM

Here's an example from the attached full build log of devel/nextest:

[...]
[num-traits 0.2.19] warning: `-C ar`: this option is deprecated and does nothing
[num-traits 0.2.19] 
     Running `CARGO=/usr/local/bin/cargo CARGO_CRATE_NAME=anstyle CARGO_MANIFEST_DIR=/wrkdirs/usr/ports/devel/nextest/work/nextest-cargo-nextest-0.9.118/cargo-crates/anstyle-1.0.10 CARGO_MANIFEST_PATH=/wrkdirs/usr/ports/devel/nextest/work/nextest-cargo-nextest-0.9.118/cargo-crates/anstyle-1.0.10/Cargo.toml CARGO_PKG_AUTHORS='' CARGO_PKG_DESCRIPTION='ANSI text styling' CARGO_PKG_HOMEPAGE='https://github.com/rust-cli/anstyle' CARGO_PKG_LICENSE='MIT OR Apache-2.0' CARGO_PKG_LICENSE_FILE='' CARGO_PKG_NAME=anstyle CARGO_PKG_README=README.md CARGO_PKG_REPOSITORY='https://github.com/rust-cli/anstyle.git' CARGO_PKG_RUST_VERSION=1.66.0 CARGO_PKG_VERSION=1.0.10 CARGO_PKG_VERSION_MAJOR=1 CARGO_PKG_VERSION_MINOR=0 CARGO_PKG_VERSION_PATCH=10 CARGO_PKG_VERSION_PRE='' LD_LIBRARY_PATH=/wrkdirs/usr/ports/devel/nextest/work/target/release/deps /usr/local/bin/rustc --crate-name anstyle --edition=2021 /wrkdirs/usr/ports/devel/nextest/work/nextest-cargo-nextest-0.9.118/cargo-crates/anstyle-1.0.10/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --crate-type lib --emit=dep-info,metadata,link -C opt-level=3 -C panic=abort -C linker-plugin-lto -C codegen-units=1 --warn=rust_2018_idioms '--warn=clippy::zero_sized_map_values' '--warn=clippy::wildcard_imports' '--warn=clippy::verbose_file_reads' --warn=unused_qualifications --warn=unused_macro_rules --warn=unused_lifetimes --warn=unsafe_op_in_unsafe_fn --warn=unreachable_pub '--warn=clippy::uninlined_format_args' '--warn=clippy::trait_duplication_in_bounds' '--warn=clippy::todo' '--warn=clippy::string_to_string' '--warn=clippy::string_lit_as_bytes' '--warn=clippy::string_add_assign' '--warn=clippy::string_add' '--warn=clippy::str_to_string' '--warn=clippy::semicolon_if_nothing_returned' '--warn=clippy::self_named_module_files' '--warn=clippy::same_functions_in_if_condition' '--warn=clippy::rest_pat_in_fully_bound_structs' '--warn=clippy::ref_option_ref' '--warn=clippy::redundant_feature_names' '--warn=clippy::rc_mutex' '--warn=clippy::ptr_as_ptr' '--warn=clippy::path_buf_push_overwrite' '--warn=clippy::negative_feature_names' '--warn=clippy::needless_for_each' '--warn=clippy::needless_continue' '--warn=clippy::mutex_integer' '--warn=clippy::mem_forget' '--warn=clippy::macro_use_imports' '--warn=clippy::lossy_float_literal' '--warn=clippy::linkedlist' '--allow=clippy::let_and_return' '--warn=clippy::large_types_passed_by_value' '--warn=clippy::large_stack_arrays' '--warn=clippy::large_digit_groups' '--warn=clippy::invalid_upcast_comparisons' '--warn=clippy::infinite_loop' '--warn=clippy::inefficient_to_string' '--warn=clippy::inconsistent_struct_constructor' '--warn=clippy::imprecise_flops' '--warn=clippy::implicit_clone' '--allow=clippy::if_same_then_else' '--warn=clippy::from_iter_instead_of_collect' '--warn=clippy::fn_params_excessive_bools' '--warn=clippy::float_cmp_const' '--warn=clippy::flat_map_option' '--warn=clippy::filter_map_next' '--warn=clippy::fallible_impl_from' '--warn=clippy::explicit_into_iter_loop' '--warn=clippy::explicit_deref_methods' '--warn=clippy::expl_impl_clone_on_copy' '--warn=clippy::enum_glob_use' '--warn=clippy::empty_enum' '--warn=clippy::doc_markdown' '--warn=clippy::debug_assert_with_mut_call' '--warn=clippy::dbg_macro' '--warn=clippy::create_dir' '--allow=clippy::collapsible_else_if' '--warn=clippy::checked_conversions' '--allow=clippy::branches_sharing_code' '--allow=clippy::bool_assert_comparison' --cfg 'feature="default"' --cfg 'feature="std"' --check-cfg 'cfg(docsrs,test)' --check-cfg 'cfg(feature, values("default", "std"))' -C metadata=d8a2d96bd0a2384d -C extra-filename=-264fd22b6bea8d87 --out-dir /wrkdirs/usr/ports/devel/nextest/work/target/release/deps -L dependency=/wrkdirs/usr/ports/devel/nextest/work/target/release/deps --cap-lints warn -C target-cpu=znver3 -C ar=ar -C linker=cc`
[num-traits 0.2.19] cargo:rustc-check-cfg=cfg(has_total_cmp)
[num-traits 0.2.19] warning: `-C ar`: this option is deprecated and does nothing
[num-traits 0.2.19] 
[num-traits 0.2.19] cargo:rustc-cfg=has_total_cmp
[num-traits 0.2.19] cargo:rerun-if-changed=build.rs
   Compiling unicode-linebreak v0.1.5
warning: `anstyle-query` (lib) generated 1 warning (1 duplicate)
   Compiling is_ci v1.2.0
warning: `percent-encoding` (lib) generated 1 warning (1 duplicate)
   Compiling colorchoice v1.0.3
warning: `proc-macro2` (lib) generated 1 warning (1 duplicate)
   Compiling either v1.15.0
warning: `typenum` (build script) generated 1 warning (1 duplicate)
[...]

{F142736160}

siva added a comment.Tue, Jan 27, 3:50 PM

Anything further for this review?

michaelo added a comment.Tue, Jan 27, 3:53 PM
In D54619#1255317, @siva wrote:

Anything further for this review?

See patch in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=292713

Mikael Urankar <mikael@FreeBSD.org> mentioned this in R11:78c933ad0ae2: lang/rust: Update to 1.93.0.Wed, Jan 28, 8:49 AM
michaelo added a comment.Wed, Jan 28, 9:47 AM

This has been implicitly fixed by 78c933ad0ae2d48b627179958af56aedf623d97a.

Revision Contents
Changeset List

PathSize
Mk/
Uses/
2 lines

Diff 169390

View Options

Mk/Uses/cargo.mk

Loading...