Page MenuHomeFreeBSD

Uses/cargo: remove deprecated '-C ar=' from RUSTFLAGS
Needs ReviewPublic

Authored by siva on Fri, Jan 9, 3:48 PM.
Tags
None
Referenced Files
F142227428: D54619.id.diff
Sat, Jan 17, 12:52 PM
Unknown Object (File)
Thu, Jan 15, 9:21 PM
Unknown Object (File)
Thu, Jan 15, 8:36 AM
Unknown Object (File)
Thu, Jan 15, 6:08 AM
Unknown Object (File)
Mon, Jan 12, 2:55 AM
Unknown Object (File)
Sat, Jan 10, 5:13 AM
Unknown Object (File)
Sat, Jan 10, 12:47 AM
Unknown Object (File)
Sat, Jan 10, 12:11 AM
Subscribers

Details

Reviewers
None
Group Reviewers
rust
Summary

This removes a lot of redundant deprecation warning reports.

See https://doc.rust-lang.org/rustc/codegen-options/index.html#ar

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

siva requested review of this revision.Fri, Jan 9, 3:48 PM
siva created this revision.

Can you investigate when this has been dropped?

Maybe you should check these as well:

$ grep -r --include=Makefile ar= .
./astro/gpsd/Makefile:GEOSTAR_MAKE_ARGS_OFF=            geostar=no
./audio/cardinal/Makefile:BINARY_ALIAS= gcc-ar=ar \
./databases/leofs/Makefile:     leo-project/bear=0.8.2-for-leofs:bear \
./devel/electron37/Makefile:                    ar=${LOCALBASE}/bin/llvm-ar${LLVM_DEFAULT} \
./devel/electron38/Makefile:                    ar=${LOCALBASE}/bin/llvm-ar${LLVM_DEFAULT} \
./devel/electron39/Makefile:                    ar=${LOCALBASE}/bin/llvm-ar${LLVM_DEFAULT} \
./editors/libreoffice/Makefile:                 --with-commons-codec-jar=${JAVAJARDIR}/commons-codec.jar \
./editors/libreoffice/Makefile:                 --with-commons-httpclient-jar=${JAVAJARDIR}/commons-httpclient.jar \
./editors/libreoffice/Makefile:                 --with-commons-lang-jar=${JAVAJARDIR}/commons-lang3.jar \
./editors/libreoffice/Makefile:                 --with-commons-logging-jar=${JAVAJARDIR}/commons-logging.jar \
./editors/libreoffice/Makefile:         --with-external-tar=${DISTDIR}/${DIST_SUBDIR} \
./editors/openoffice-4/Makefile:        commons-codec-jar=${JAVALIBDIR}/commons-codec.jar              \
./editors/openoffice-4/Makefile:        commons-httpclient-jar=${JAVALIBDIR}/commons-httpclient.jar    \
./editors/openoffice-4/Makefile:        commons-logging-jar=${JAVALIBDIR}/commons-logging.jar
./editors/openoffice-4/Makefile:                        --with-commons-lang-jar=${JAVALIBDIR}/commons-lang.jar \
./editors/openoffice-4/Makefile:                        --with-beanshell-jar=${JAVALIBDIR}/bsh.jar     \
./editors/openoffice-4/Makefile:                        --with-lucene-core-jar=${JAVALIBDIR}/lucene-core-3.6.2.jar \
./editors/openoffice-4/Makefile:                        --with-lucene-analyzers-jar=${JAVALIBDIR}/lucene-analyzers-3.6.2.jar \
./editors/openoffice-devel/Makefile:    commons-codec-jar=${JAVALIBDIR}/commons-codec.jar              \
./editors/openoffice-devel/Makefile:    commons-httpclient-jar=${JAVALIBDIR}/commons-httpclient.jar
./editors/openoffice-devel/Makefile:CONFIGURE_ARGS+=    --with-commons-logging-jar=${JAVALIBDIR}/commons-logging.jar
./editors/openoffice-devel/Makefile:                    --with-commons-lang-jar=${JAVALIBDIR}/commons-lang3.jar \
./editors/openoffice-devel/Makefile:                    --with-beanshell-jar=${JAVALIBDIR}/bsh.jar     \
./editors/openoffice-devel/Makefile:                    --with-lucene-core-jar=${JAVALIBDIR}/lucene-core-3.6.2.jar \
./editors/openoffice-devel/Makefile:                    --with-lucene-analyzers-jar=${JAVALIBDIR}/lucene-analyzers-3.6.2.jar \
./filesystems/rar2fs/Makefile:          --with-unrar=`${MAKE} -C ${PORTSDIR}/${LIBUNRAR_PORT} -VWRKSRC` \
./graphics/frogr/Makefile:MESON_ARGS=   -Denable-header-bar=true
./graphics/libskiasharp/Makefile:               ar=${LOCALBASE}/bin/ar
./graphics/rawtherapee/Makefile:BINARY_ALIAS+=  ar=${AR} ranlib=${RANLIB}
./graphics/skia/Makefile:               ar=llvm-ar
./java/apache-commons-beanutils/Makefile:MAKE_ARGS+=    -Dcommons-collections.jar=${JAVALIBDIR}/commons-collections.jar \
./java/apache-commons-beanutils/Makefile:               -Dcommons-logging.jar=${JAVALIBDIR}/commons-logging.jar
./java/javahelp/Makefile:MAKE_ARGS=     -Djsp-jar=${TOMCAT_jsp} \
./java/javahelp/Makefile:               -Dfile.reference.jsp-api.jar=${TOMCAT_jsp} \
./java/javahelp/Makefile:               -Dservlet-jar=${TOMCAT_servlet} \
./java/javahelp/Makefile:               -Dfile.reference.servlet-api.jar=${TOMCAT_servlet} \
./java/javamail/Makefile:MAKE_ARGS+=    -Dactivation.jar=${DISTDIR}/jakarta.activation.jar
./java/sigar/Makefile:          -Djunit.jar="${JAVALIBDIR}/junit.jar" test
./lang/rust/Makefile:   @${ECHO_CMD} 'ar="${AR}"' >> ${WRKSRC}/config.toml
./lang/rust188/Makefile:        @${ECHO_CMD} 'ar="${AR}"' >> ${WRKSRC}/config.toml
./math/octave-forge-rtree/Makefile:BINARY_ALIAS=        tar=gtar
./math/polymake/Makefile:SINGULAR_CONFIGURE_ON= --with-singular=${LOCALBASE}
./misc/amanda-server/Makefile:          --with-gnutar=${LOCALBASE}/bin/gtar
./net-im/ejabberd/Makefile:CONFIGURE_ARGS+=--localstatedir=/var --libdir=${PREFIX}/${EJABBERD_LIBDIR} --with-rebar=rebar
./security/courier-authlib/Makefile:            --with-authdaemonvar=${AUTHDAEMONVAR} \
./sysutils/edk2/Makefile:               ar=${AR} \
./sysutils/edk2/Makefile:               gcc-ar=${LOCALBASE}/bin/${CC:S/gcc/&-ar/} \
./www/chromium/Makefile:                        ar=${LOCALBASE}/bin/llvm-ar${LLVM_DEFAULT} \
./www/iridium/Makefile:                 ar=${LOCALBASE}/bin/llvm-ar${LLVM_DEFAULT} \
./www/onlyoffice-documentserver/Makefile:BINARY_ALIAS+= ar=${LOCALBASE}/bin/llvm-ar${LLVM_DEFAULT} \
./www/ungoogled-chromium/Makefile:                      ar=${LOCALBASE}/bin/llvm-ar${LLVM_DEFAULT

Yes, I can look into each of those ports in a future review. This review is narrowly scoped to just RUSTFLAGS, can we get this in first?

Also, a lot of those are false positives due to 'jar=' matching on Java ports as well. I'll look into it properly soon and post a review fixing the ones that need fixing.