Differential D795

Add macros to simplify access to the system registers
ClosedPublic
Actions

Authored by andrew on Sep 17 2014, 10:06 PM.

Details

Reviewers

rpaulo

Group Reviewers

ARM

Commits

rS272209: Add machine/sysreg.h to simplify accessing the system control coprocessor

Summary

Macros from Svatopluk Kraus and Michal Meloun. May need more cleanup.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

andrew updated this revision to Diff 1670.Sep 17 2014, 10:06 PM

andrew retitled this revision from to Add macros to simplify access to the system registers.

andrew updated this object.

andrew edited the test plan for this revision. (Show Details)

andrew added a reviewer: ARM.

I've only compiled this, not tested on hardware or verified the obj files with and without the patch are the same.

I think it's a good cleanup and it's easy to verify that nothing changed.

sys/arm/include/sysreg.h
29	This file should probably include the header from which __ARM_ARCH comes from.

This revision is now accepted and ready to land.Sep 18 2014, 7:26 PM

No objections. Something about this just doesn't thrill me, I think I'd rather see real asm macros, but there's nothing about this that makes it harder to convert to real macros later (in fact, this probably makes it easier). I sure hope all the #defines have been double and tripple checked, this is just the sort of thing where tiny cut and paste errors can make for difficult debugging.