Page MenuHomeFreeBSD
Differential D5997

Extract "long" make target into scripts.
ClosedPublic
Actions

Authored by mat on Apr 19 2016, 1:07 PM.
Tags
None
Referenced Files
F136145067: D5997.id16622.diff
Sun, Nov 16, 3:59 AM
Unknown Object (File)
Fri, Nov 14, 6:44 AM
Unknown Object (File)
Wed, Nov 12, 6:28 AM
Unknown Object (File)
Wed, Nov 12, 6:27 AM
Unknown Object (File)
Tue, Nov 11, 2:11 AM
Unknown Object (File)
Sun, Nov 9, 10:00 PM
Unknown Object (File)
Sun, Nov 9, 5:24 PM
Unknown Object (File)
Sun, Nov 9, 4:27 PM
View All Files
Subscribers
bdrewery
sunpoet

Details

Reviewers
None
Group Reviewers
portmgr
Commits
rP415842: Extract the larger bsd.port.mk targets into separate scripts.
Summary

Extract check-vulnerable target.
Extract do-fetch, fetch-list, fetch-url-list-int and fetch-urlall-list.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 3853
Build 3896: arc lint + arc unit

Event Timeline

mat updated this revision to Diff 15314.Apr 19 2016, 1:07 PM
mat retitled this revision from to Extract "long" make target into scripts..
mat updated this object.
mat edited the test plan for this revision. (Show Details)
Herald added a reviewer: portmgr. · View Herald TranscriptApr 19 2016, 1:07 PM
mat updated this revision to Diff 15316.Apr 19 2016, 1:14 PM
mat edited edge metadata.

Spot a mistake.

Herald edited edge metadata. · View Herald TranscriptApr 19 2016, 1:14 PM
mat updated this revision to Diff 15317.Apr 19 2016, 1:15 PM
mat edited edge metadata.

And with the correct fix.

Herald edited edge metadata. · View Herald TranscriptApr 19 2016, 1:15 PM
mat updated this revision to Diff 15318.Apr 19 2016, 1:54 PM
mat edited edge metadata.
  • Extract makesum.
Herald edited edge metadata. · View Herald TranscriptApr 19 2016, 1:54 PM
mat updated this revision to Diff 15319.Apr 19 2016, 2:08 PM
mat edited edge metadata.
  • Extract makesum.
Herald edited edge metadata. · View Herald TranscriptApr 19 2016, 2:08 PM
mat updated this revision to Diff 15437.Apr 21 2016, 11:29 AM
mat edited edge metadata.

update the makesum.sh to validate all of it's environment.

Herald edited edge metadata. · View Herald TranscriptApr 21 2016, 11:29 AM
mat updated this revision to Diff 15438.Apr 21 2016, 12:28 PM
mat edited edge metadata.
  • Extract checksum.
  • Extract makesum.
  • Do the fetching directly when running makesum.
  • Extract check-checksum-algorithms.
Herald edited edge metadata. · View Herald TranscriptApr 21 2016, 12:28 PM
mat updated this revision to Diff 16051.May 9 2016, 2:45 PM
mat edited edge metadata.
  • Fix PATCHFILES.
  • Handle ports with no DISTFILES.
Herald edited edge metadata. · View Herald TranscriptMay 9 2016, 2:45 PM
mat updated this revision to Diff 16475.May 17 2016, 4:01 PM
mat edited edge metadata.

Rebase, include the TIMESTAMP bits in makesum.

mat updated this revision to Diff 16622.May 20 2016, 2:36 PM

rebase.

bdrewery added a subscriber: bdrewery.May 20 2016, 9:07 PM

Awesome! If an exp-run works then just do it.

bdrewery added a comment.May 20 2016, 9:08 PM

Looks like you need to update this with your debug feature.

mat added a comment.May 21 2016, 8:42 AM
In D5997#137279, @bdrewery wrote:

Awesome! If an exp-run works then just do it.

It's currently being tested in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=208916

In D5997#137281, @bdrewery wrote:

Looks like you need to update this with your debug feature.

Yes, I added it on my local repo but did not update the review.

mat updated this revision to Diff 16723.May 23 2016, 12:52 PM

Rebase, and:

  • Fix PATCHFILES handling.
  • Add debug hooks.
mat updated this revision to Diff 16725.May 23 2016, 1:10 PM
  • Escape/unescape bits when needed.
mat updated this revision to Diff 16726.May 23 2016, 1:32 PM
  • Make RANDOMIZE_MASTER_SITES work again.
Closed by commit rP415842: Extract the larger bsd.port.mk targets into separate scripts. (authored by mat). · Explain WhyMay 25 2016, 3:58 PM
This revision was automatically updated to reflect the committed changes.
sunpoet added a subscriber: sunpoet.May 28 2016, 3:09 PM

I got error message as follows:

% make fetch-urlall-list
=> /usr/ports/distfiles/ is not writable by you; cannot fetch.
*** Error code 1

Stop.

Revision Contents
Changeset List

PathSize
Mk/
Scripts/
35 lines
89 lines
171 lines
28 lines
51 lines
621 lines

Diff 16622

View Options

Mk/Scripts/check-vulnerable.sh

Loading...
View Options

Mk/Scripts/checksum.sh

Loading...
View Options

Mk/Scripts/do-fetch.sh

Loading...
View Options

Mk/Scripts/functions.sh

Loading...
View Options

Mk/Scripts/makesum.sh

Loading...
View Options

Mk/bsd.port.mk

Loading...