Page MenuHomeFreeBSD

Extract "long" make target into scripts.
ClosedPublic

Authored by mat on Apr 19 2016, 1:07 PM.

Details

Summary

Extract check-vulnerable target.
Extract do-fetch, fetch-list, fetch-url-list-int and fetch-urlall-list.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mat updated this revision to Diff 15314.Apr 19 2016, 1:07 PM
mat retitled this revision from to Extract "long" make target into scripts..
mat updated this object.
mat edited the test plan for this revision. (Show Details)
mat updated this revision to Diff 15316.Apr 19 2016, 1:14 PM
mat edited edge metadata.

Spot a mistake.

mat updated this revision to Diff 15317.Apr 19 2016, 1:15 PM
mat edited edge metadata.

And with the correct fix.

mat updated this revision to Diff 15318.Apr 19 2016, 1:54 PM
mat edited edge metadata.
  • Extract makesum.
mat updated this revision to Diff 15319.Apr 19 2016, 2:08 PM
mat edited edge metadata.
  • Extract makesum.
mat updated this revision to Diff 15437.Apr 21 2016, 11:29 AM
mat edited edge metadata.

update the makesum.sh to validate all of it's environment.

mat updated this revision to Diff 15438.Apr 21 2016, 12:28 PM
mat edited edge metadata.
  • Extract checksum.
  • Extract makesum.
  • Do the fetching directly when running makesum.
  • Extract check-checksum-algorithms.
mat updated this revision to Diff 16051.May 9 2016, 2:45 PM
mat edited edge metadata.
  • Fix PATCHFILES.
  • Handle ports with no DISTFILES.
mat updated this revision to Diff 16475.May 17 2016, 4:01 PM
mat edited edge metadata.

Rebase, include the TIMESTAMP bits in makesum.

mat updated this revision to Diff 16622.May 20 2016, 2:36 PM

rebase.

Awesome! If an exp-run works then just do it.

Looks like you need to update this with your debug feature.

mat added a comment.May 21 2016, 8:42 AM

Awesome! If an exp-run works then just do it.

It's currently being tested in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=208916

Looks like you need to update this with your debug feature.

Yes, I added it on my local repo but did not update the review.

mat updated this revision to Diff 16723.May 23 2016, 12:52 PM

Rebase, and:

  • Fix PATCHFILES handling.
  • Add debug hooks.
mat updated this revision to Diff 16725.May 23 2016, 1:10 PM
  • Escape/unescape bits when needed.
mat updated this revision to Diff 16726.May 23 2016, 1:32 PM
  • Make RANDOMIZE_MASTER_SITES work again.
This revision was automatically updated to reflect the committed changes.

I got error message as follows:

% make fetch-urlall-list
=> /usr/ports/distfiles/ is not writable by you; cannot fetch.
*** Error code 1

Stop.