Differential D53364

blocklist: Fix rcorder(8)
ClosedPublic
Actions

Authored by jlduran on Oct 26 2025, 4:30 PM.

Details

Reviewers

0mp

Group Reviewers

Commits

rG7af5c1da2887: blocklist: Fix rcorder(8)
rG79e374217d69: blocklist: Fix rcorder(8)

Summary

The blocklist daemon depends on a packet filter in order to block.

Add all supported packet filters to the REQUIRE line, not just pf, to
indicate rcorder(8) that it should start after the packet filter service
has started.

While here, change the mode of the rc file to include the executable
bit, just like the rest of the files in the rc.d source directory.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 68127
Build 65010: arc lint + arc unit

Event Timeline

jlduran created this revision.Oct 26 2025, 4:30 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 26 2025, 4:30 PM

jlduran requested review of this revision.Oct 26 2025, 4:30 PM

Harbormaster completed remote builds in B68127: Diff 165077.Oct 26 2025, 4:30 PM

Note: we could perhaps think about adding a FIREWALL script to depend on instead, but for the time being this patch is fine. Thanks!

This revision is now accepted and ready to land.Oct 27 2025, 3:18 PM

In D53364#1219018, @0mp wrote:

Note: we could perhaps think about adding a FIREWALL script to depend on instead, but for the time being this patch is fine. Thanks!

That is a great suggestion, thank you!

Closed by commit rG79e374217d69: blocklist: Fix rcorder(8) (authored by jlduran). · Explain WhyOct 27 2025, 3:48 PM

This revision was automatically updated to reflect the committed changes.

jlduran added a commit: rG79e374217d69: blocklist: Fix rcorder(8).

jlduran added a commit: rG7af5c1da2887: blocklist: Fix rcorder(8).Oct 30 2025, 1:53 AM