Sponsored-by: The FreeBSD Foundation
Diff Detail
Diff Detail
- Repository
- R11 FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 68079 Build 64962: arc lint + arc unit
Event Timeline
Comment Actions
We need an entry in java/Makefile.
| java/openjdk25/Makefile | ||
|---|---|---|
| 5 | This line should be removed. | |
Comment Actions
Yeah, updated the patch. Also added to Mk/Uses/java.mk, hopefully without any errors.
| java/openjdk25/Makefile | ||
|---|---|---|
| 5 | Your latest update and my comment collided. It's the PORTREVSION=1 line that should be removed. | |
Comment Actions
The build is failing because configure is unhappy with the bootstrap version.
configure: Found potential Boot JDK using configure arguments configure: Potential Boot JDK found at /usr/local/openjdk23 is incorrect JDK version (openjdk version "23.0.2" 2025-01-21 OpenJDK Runtime Environment (build 23.0.2+7-2) OpenJDK 64-Bit Server VM (build 23.0.2+7-2, mixed mode, sharing)); ignoring configure: (Your Boot JDK version must be one of: 24 25) configure: error: The path given by --with-boot-jdk does not contain a valid Boot JDK configure exiting with result code 1
Comment Actions
Thanks! Had updated the dependency if it was already installed, but not on clean install.
Comment Actions
Please check the marked comments.
Please provide the exact commit message you plan to use, ideally upload the commit to some privat repository and link it here so I can check if it's compliant with committer's guide. Make sure it has “Approved by: fuz (mentor)” in it.
| java/openjdk25/Makefile | ||
|---|---|---|
| 3 | Is that variable necessary with the current way the distfile is procured? It does not look like it is. | |
| 14 | This comment is out of date. | |
| 38 | This line can be removed: GH_PROJECT defaults to PORTNAME. | |
| 39 | If you are in control over upstream's versioning, it would be ideal if the tag name is just ${DISTVERSIONFULL}. You can adjust DISTVERSIONPREFIX and DISTVERSIONPREFIX to make that work in most cases. | |
Comment Actions
I think it's best if @haraldei just updates the SUMMARY of this review with the exact commit message.
Preferably in the following format:
java/openjdk25: New port <pkg-descr> WWW: <URL from WWW> Sponsored-by: The FreeBSD Foundation Reviewed by: <if any other person contributed to this review for instance jrm here> Approved by: fuz (mentor) Differential Revision: <URL to this page>
| java/openjdk25/pkg-message | ||
|---|---|---|
| 5 | I think this should be require not requires | |
Comment Actions
Thanks a lot for the review, I'll squash and update the summary/commit message once the diff is accepted.
| java/openjdk25/Makefile | ||
|---|---|---|
| 3 | It wasn't, but with the changes below I needed it again. | |
| 39 | We are technically in control, but I try to stay close to the upstream tags, so it's easy to see which upstream version our port is based on. I think I found a way to achieve that and still remove this line. | |
Comment Actions
Looks good. Please post the commit message you are going to use and then we should be ready for commit.
Comment Actions
java/openjdk25: New port
An open-source implementation of the Java Platform, Standard Edition.
WWW: https://openjdk.java.net/projects/jdk/25/
Sponsored-by: The FreeBSD Foundation
Reviewed by: jrm,bofh
Approved by: fuz (mentor)
Differential Revision: https://reviews.freebsd.org/D53326
Comment Actions
Needs a space in Reviewed by: jrm,bofh between jrm, and bofh.
Otherwise good. Please proceed with a commit!
Comment Actions
There is some other formatting that looks a bit off in the commit message. Harald, have a look at the commit template: https://docs.freebsd.org/en/articles/committers-guide/#git-mini-primer-getting-started
It's helpful for these fields to be standardized when searching the logs.
Comment Actions
java/openjdk25: New port
An open-source implementation of the Java Platform, Standard Edition.
WWW: https://openjdk.java.net/projects/jdk/25/
Reviewed by: jrm, bofh
Approved by: fuz (mentor)
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D53326
Comment Actions
Hopefully the commit message is better now. Used the template so field should be in order and values align, though it's not visible in the differential summary.