Page MenuHomeFreeBSD
Differential D53297

www/forgejo: Update to 13.0.1 and assume maintainership
ClosedPublic
Actions

Authored by des on Thu, Oct 23, 11:57 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 2, 2:20 AM
Unknown Object (File)
Fri, Oct 31, 1:14 PM
Unknown Object (File)
Fri, Oct 31, 9:38 AM
Unknown Object (File)
Fri, Oct 31, 2:32 AM
Unknown Object (File)
Thu, Oct 30, 6:00 PM
Unknown Object (File)
Thu, Oct 30, 6:00 PM
Unknown Object (File)
Thu, Oct 30, 6:00 PM
Unknown Object (File)
Thu, Oct 30, 1:23 PM
View All 31 Files
Subscribers
arrowd

Details

Reviewers
arrowd
bapt
Commits
R11:a495f254cf3d: www/forgejo: Update to 13.0.1 and assume maintainership
R11:f0fec200720c: www/forgejo: Update to 13.0.1 and assume maintainership
Summary

Changelog:

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 68057
Build 64940: arc lint + arc unit

Event Timeline

des requested review of this revision.Thu, Oct 23, 11:57 AM
des created this revision.
Harbormaster completed remote builds in B68044: Diff 164878.Thu, Oct 23, 11:57 AM
arrowd added a subscriber: arrowd.Thu, Oct 23, 5:33 PM
arrowd added inline comments.
www/forgejo/Makefile
28–29
69–70

All these knobs can be moved before the .include <bsd.port.options.mk> block.

70

No need for += there.

des marked 2 inline comments as done.Thu, Oct 23, 7:14 PM
des added inline comments.
www/forgejo/Makefile
28–29

No, that results in SUB_LIST containing conflicting definitions of DATADIR, ETCDIR etc.

des updated this revision to Diff 164903.Thu, Oct 23, 7:14 PM

rf

Harbormaster completed remote builds in B68057: Diff 164903.Thu, Oct 23, 7:14 PM
arrowd accepted this revision.Thu, Oct 23, 7:19 PM

This LGTM.

www/forgejo/Makefile
52

No need for += here too.

This revision is now accepted and ready to land.Thu, Oct 23, 7:19 PM
des updated this revision to Diff 164904.Thu, Oct 23, 7:22 PM

rf

This revision now requires review to proceed.Thu, Oct 23, 7:22 PM
Harbormaster completed remote builds in B68058: Diff 164904.Thu, Oct 23, 7:22 PM
des marked an inline comment as done.Thu, Oct 23, 7:23 PM
bapt accepted this revision.Thu, Oct 23, 7:43 PM
This revision is now accepted and ready to land.Thu, Oct 23, 7:43 PM
Closed by commit R11:f0fec200720c: www/forgejo: Update to 13.0.1 and assume maintainership (authored by des). · Explain WhyThu, Oct 23, 9:06 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: R11:f0fec200720c: www/forgejo: Update to 13.0.1 and assume maintainership.
des added a commit: R11:a495f254cf3d: www/forgejo: Update to 13.0.1 and assume maintainership.Tue, Oct 28, 11:52 AM

Revision Contents
Changeset List

PathSize
www/
forgejo/
40 lines
6 lines
files/
18 lines
2 lines
10 lines

Diff 164903

View Options

www/forgejo/Makefile

Loading...
View Options

www/forgejo/distinfo

Loading...
View Options

www/forgejo/files/app.ini.sample.in

Loading...
View Options

www/forgejo/files/forgejo.in

Loading...
View Options

www/forgejo/pkg-plist

Loading...