Page MenuHomeFreeBSD
Differential D6363

Rework managing hotplug commands with command completions.
ClosedPublic
Actions

Authored by jhb on May 14 2016, 1:26 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 6, 12:11 AM
Unknown Object (File)
Mon, May 4, 3:43 PM
Unknown Object (File)
Sat, May 2, 10:34 PM
Unknown Object (File)
Thu, Apr 30, 6:06 PM
Unknown Object (File)
Thu, Apr 30, 7:04 AM
Unknown Object (File)
Wed, Apr 29, 11:33 PM
Unknown Object (File)
Wed, Apr 29, 2:23 PM
Unknown Object (File)
Tue, Apr 28, 6:23 PM
View All Files
Subscribers
None

Details

Reviewers
imp
Commits
rS300074: Rework managing hotplug commands with command completions.
Summary

Rework managing hotplug commands with command completions.

Previously the command completion interrupt would post any pending
command immediately, but before pcib_pcie_hotplug_update() had been
run to inspect the current status. Now, the command completion
interrupt merely clears the flag and stops the timer assuming that
the caller is always going to call pcib_pcie_hotplug_update() to
generate the next hotplug command if one is needed.

Test Plan
  • only tested ExpressCard to ensure no regressions, but that doesn't actually use command completion interrupts. :(

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3792
Build 3835: arc lint + arc unit

Event Timeline

jhb updated this revision to Diff 16321.May 14 2016, 1:26 AM
jhb retitled this revision from to Rework managing hotplug commands with command completions..
jhb updated this object.
jhb edited the test plan for this revision. (Show Details)
jhb added a reviewer: imp.
jhb added inline comments.May 14 2016, 1:29 AM
sys/dev/pci/pci_pci.c
893–902

Since pcib_pcie_hotplug_update() always updates the full mask/value now, I think I can probably get rid of the pending things entirely and just write whatever values are needed for the current state after a command completion interrupt posts.

1022

This was the only place that wasn't already setting the mask on every update. Here though we want to be sure to not change the EI's state (so write a zero to the bit) if it's in the correct setting already.

jhb updated this revision to Diff 16436.May 17 2016, 3:28 AM
  • Drop the pending link fields entirely.
  • Write the new value, not the old.
jhb updated this revision to Diff 16437.May 17 2016, 3:36 AM
jhb updated this object.

Updated commit message for removal of pending fields.

jhb updated this revision to Diff 16483.May 17 2016, 7:44 PM

Refresh

Closed by commit rS300074: Rework managing hotplug commands with command completions. (authored by jhb). · Explain WhyMay 17 2016, 7:48 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
dev/
pci/
64 lines
2 lines

Diff 16483

View Options

sys/dev/pci/pci_pci.c

Loading...
View Options

sys/dev/pci/pcib_private.h

Loading...