Page MenuHomeFreeBSD
Differential D52889

ahci: Don't fail attach if the MSI-X BARs cannot be allocated
ClosedPublic
Actions

Authored by jhb on Oct 3 2025, 4:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Sep 5, 12:38 PM
Unknown Object (File)
Thu, Sep 3, 10:59 PM
Unknown Object (File)
Thu, Sep 3, 5:43 AM
Unknown Object (File)
Thu, Sep 3, 1:39 AM
Unknown Object (File)
Tue, Sep 1, 11:01 PM
Unknown Object (File)
Tue, Sep 1, 9:54 PM
Unknown Object (File)
Tue, Sep 1, 5:58 AM
Unknown Object (File)
Sun, Aug 30, 10:47 PM
View All Files
Subscribers
imp

Details

Reviewers
avg
imp
Commits
rG07f4fa7a0db9: ahci: Don't fail attach if the MSI-X BARs cannot be allocated
rGfb939e88ba19: ahci: Don't fail attach if the MSI-X BARs cannot be allocated
rGb658158e9396: ahci: Don't fail attach if the MSI-X BARs cannot be allocated
Summary

If the MSI-X table and/or PBA live in separate BAR(s) and those BAR(s)
cannot be allocated, fall back to using MSI or INTx instead of failing
attach.

PR: 289748
Reported by: Vitalij Satanivskij <satan@Ukr.net>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb created this revision.Oct 3 2025, 4:40 PM
Herald added a subscriber: imp. · View Herald TranscriptOct 3 2025, 4:40 PM
jhb requested review of this revision.Oct 3 2025, 4:40 PM
Harbormaster completed remote builds in B67523: Diff 163454.Oct 3 2025, 4:40 PM
jhb added a parent revision: D52888: ahci: Use pci_msix_*_bar instead of reading config registers directly.Oct 3 2025, 4:40 PM
imp accepted this revision.Oct 3 2025, 4:52 PM
This revision is now accepted and ready to land.Oct 3 2025, 4:52 PM
avg added inline comments.Oct 3 2025, 5:16 PM
sys/dev/ahci/ahci_pci.c
595

If we got here then we successfully allocated r_msix_table.
Then it probably would be a good idea to release it?

avg accepted this revision.Oct 6 2025, 5:29 AM
jhb added inline comments.Oct 6 2025, 5:43 PM
sys/dev/ahci/ahci_pci.c
595

Maybe, but it doesn't hurt to keep it mapped (and the PCI bus won't actually unmap the BAR if we do anyway). That seems like a very rare case that isn't worth the complexity. When the device detaches, ahci_free_mem() will release the resource.

Note though that there is a bug in ahci_pci_detach(), it needs to call pci_release_msi() before it frees the BARs.

Closed by commit rGb658158e9396: ahci: Don't fail attach if the MSI-X BARs cannot be allocated (authored by jhb). · Explain WhyOct 6 2025, 5:57 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rGb658158e9396: ahci: Don't fail attach if the MSI-X BARs cannot be allocated.
jhb added a commit: rGfb939e88ba19: ahci: Don't fail attach if the MSI-X BARs cannot be allocated.Oct 10 2025, 9:05 PM
jhb added a commit: rG07f4fa7a0db9: ahci: Don't fail attach if the MSI-X BARs cannot be allocated.

Revision Contents
Changeset List

PathSize
sys/
dev/
ahci/
8 lines

Diff 163651

View Options

sys/dev/ahci/ahci_pci.c

Loading...