Page MenuHomeFreeBSD
Differential D52882

nss_tacplus: Fix typo MK_INSTALLIB -> MK_INSTALLLIB
ClosedPublic
Actions

Authored by jlduran on Oct 3 2025, 5:18 AM.
Tags
None
Referenced Files
F144018316: D52882.id163625.diff
Tue, Feb 3, 10:54 AM
Unknown Object (File)
Sat, Jan 31, 4:03 AM
Unknown Object (File)
Thu, Jan 29, 7:11 AM
Unknown Object (File)
Mon, Jan 12, 2:43 PM
Unknown Object (File)
Dec 30 2025, 8:45 PM
Unknown Object (File)
Dec 29 2025, 2:59 PM
Unknown Object (File)
Dec 19 2025, 9:48 PM
Unknown Object (File)
Dec 13 2025, 10:51 PM
View All 44 Files
Subscribers
imp

Details

Reviewers
des
Commits
rG869989671300: nss_tacplus: Fix typo MK_INSTALLIB -> MK_INSTALLLIB
rG8a76161c0df2: nss_tacplus: Fix typo MK_INSTALLIB -> MK_INSTALLLIB
rG8435c4112ae4: nss_tacplus: Fix typo MK_INSTALLIB -> MK_INSTALLLIB
rG75f7e003b79d: nss_tacplus: Fix typo MK_INSTALLIB -> MK_INSTALLLIB

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 67527
Build 64410: arc lint + arc unit

Event Timeline

jlduran created this revision.Oct 3 2025, 5:18 AM
Herald added a subscriber: imp. · View Herald TranscriptOct 3 2025, 5:18 AM
jlduran requested review of this revision.Oct 3 2025, 5:18 AM
Harbormaster completed remote builds in B67511: Diff 163410.Oct 3 2025, 5:18 AM
des requested changes to this revision.Oct 3 2025, 4:56 PM

Please also add usr/lib/libnss_tacplus.a to ObsoleteFiles.inc.

This revision now requires changes to proceed.Oct 3 2025, 4:56 PM
jlduran updated this revision to Diff 163468.EditedOct 3 2025, 5:11 PM

Address suggestions:

  • Add usr/lib/libnss_tacplus.a to ObsoleteFiles.inc
Harbormaster completed remote builds in B67527: Diff 163468.Oct 3 2025, 5:11 PM
des added inline comments.Oct 4 2025, 6:34 PM
ObsoleteFiles.inc
54

nss_tacplus is not a library, it's an nsswitch plugin. The comment should reflect the fact that this file was never intended to be installed.

jlduran updated this revision to Diff 163563.Oct 4 2025, 8:44 PM
  • Update the reason for removal
Harbormaster completed remote builds in B67557: Diff 163563.Oct 4 2025, 8:44 PM
des accepted this revision.Oct 6 2025, 9:30 AM
This revision is now accepted and ready to land.Oct 6 2025, 9:30 AM
Closed by commit rG75f7e003b79d: nss_tacplus: Fix typo MK_INSTALLIB -> MK_INSTALLLIB (authored by jlduran). · Explain WhyOct 6 2025, 12:55 PM
This revision was automatically updated to reflect the committed changes.
jlduran added a commit: rG75f7e003b79d: nss_tacplus: Fix typo MK_INSTALLIB -> MK_INSTALLLIB.
jlduran added a commit: rG8435c4112ae4: nss_tacplus: Fix typo MK_INSTALLIB -> MK_INSTALLLIB.Oct 7 2025, 12:34 AM
jlduran added a commit: rG8a76161c0df2: nss_tacplus: Fix typo MK_INSTALLIB -> MK_INSTALLLIB.
jlduran added a commit: rG869989671300: nss_tacplus: Fix typo MK_INSTALLIB -> MK_INSTALLLIB.

Revision Contents
Changeset List

PathSize
3 lines
lib/
nss_tacplus/
2 lines

Diff 163468

View Options

ObsoleteFiles.inc

Loading...
View Options

lib/nss_tacplus/Makefile

Loading...