databases/sqlite3: Pass --prefix to configure
ClosedPublic
Actions

Authored by ivy on Fri, Sep 19, 10:14 PM.

Details

Reviewers

vvd
arrowd

Commits

R11:17468749f972: databases/sqlite3: Pass --prefix to configure

Summary

This is required to build with a non-default ${LOCALBASE}, otherwise,
the build fails: firstly because it can't find libedit, and secondly
because it tries to install into /usr/local instead of ${PREFIX}.

PR: 288816
Approved by: maintainer (timeout, > 30 days)

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ivy requested review of this revision.Fri, Sep 19, 10:14 PM

ivy created this revision.

Harbormaster completed remote builds in B67185: Diff 162444.Fri, Sep 19, 10:14 PM

vvd accepted this revision.Sat, Sep 20, 12:57 AM

This revision is now accepted and ready to land.Sat, Sep 20, 12:57 AM

When the port has GNU_CONFIGURE=yes instead of HAS_CONFIGURE=yes, the framework passes --prefix automatically.
So the change makes sense only if the configure script shipped by sqlite is indeed non-standard.

In D52632#1202361, @arrowd wrote:

When the port has GNU_CONFIGURE=yes instead of HAS_CONFIGURE=yes, the framework passes --prefix automatically.
So the change makes sense only if the configure script shipped by sqlite is indeed non-standard.

it is indeed not GNU configure, it's a weird Tcl thing called "autosetup", and GNU_CONFIGURE isn't set in the Makefile.

arrowd accepted this revision.Mon, Sep 22, 3:23 PM

Closed by commit R11:17468749f972: databases/sqlite3: Pass --prefix to configure (authored by ivy). · Explain WhyTue, Sep 23, 9:04 PM

This revision was automatically updated to reflect the committed changes.

ivy added a commit: R11:17468749f972: databases/sqlite3: Pass --prefix to configure.