Differential D51919

libkern: Drop incorrect qsort optimization
ClosedPublic
Actions

Authored by des on Aug 15 2025, 2:04 PM.

Details

Reviewers

Group Reviewers

Commits

rG935c26dbe3a6: libkern: Drop incorrect qsort optimization
rGaf321075b4d2: libkern: Drop incorrect qsort optimization
rGef8f3e913156: libkern: Drop incorrect qsort optimization

Summary

See 5205b32de3fb for details.

PR: 287089
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 66266
Build 63149: arc lint + arc unit

Event Timeline

des created this revision.Aug 15 2025, 2:04 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 15 2025, 2:04 PM

des requested review of this revision.Aug 15 2025, 2:04 PM

Harbormaster completed remote builds in B66266: Diff 160401.Aug 15 2025, 2:04 PM

You beat me to it!

I have another revision with a semi-full sync (without qsort_s), but this is good in the meantime.
Thank you!

EDIT: Proposed in D51920

This revision is now accepted and ready to land.Aug 15 2025, 2:28 PM

des mentioned this in D51920: libkern: qsort: Sync with libc sources.Aug 15 2025, 6:00 PM

Closed by commit rGef8f3e913156: libkern: Drop incorrect qsort optimization (authored by des). · Explain WhyAug 15 2025, 11:25 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rGef8f3e913156: libkern: Drop incorrect qsort optimization.

des added a commit: rGaf321075b4d2: libkern: Drop incorrect qsort optimization.Aug 27 2025, 7:23 PM

des added a commit: rG935c26dbe3a6: libkern: Drop incorrect qsort optimization.

Revision Contents
Changeset List

Path

Size

sys/

libkern/

qsort.c

14 lines

Diff 160401

View Options

libkern: Drop incorrect qsort optimizationClosedPublicActions