[BCMA] Small fixes
ClosedPublic
Actions

Authored by mizhka on May 6 2016, 5:19 PM.

Details

Reviewers

landon_landonf.org
adrian

Commits

rS299314: [bhnd] fix bcma resource allocation for regions; EROM work around.

Summary

This patch introduces 2 small fixes:

bcma.c - assign different resource IDs for different regions
bcma_erom.c - workaround for BCM/MIPS bus enumerations

Test Plan

Tested on ASUS RT-N16 initially, double checked on ASUS RT-N53

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

mizhka updated this revision to Diff 15980.May 6 2016, 5:19 PM

mizhka retitled this revision from to [BCMA] Small fixes.

mizhka updated this object.

mizhka edited the test plan for this revision. (Show Details)

mizhka added reviewers: adrian, landon_landonf.org.

mizhka set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptMay 6 2016, 5:19 PM

Other than minor style(9) issue, looks good to me.

sys/dev/bhnd/bcma/bcma_erom.c
893	I think this needs to be line-wrapped as per style(9)'s 80 char limit.

This revision now requires changes to proceed.May 6 2016, 8:40 PM

Fixed line size (now less 80 chars)

mizhka marked an inline comment as done.May 7 2016, 10:22 PM

Looks good to me. Tested against a BCM4331 bridged device.

This revision is now accepted and ready to land.May 10 2016, 12:17 AM

Closed by commit rS299314: [bhnd] fix bcma resource allocation for regions; EROM work around. (authored by adrian). · Explain WhyMay 10 2016, 4:56 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

dev/

bhnd/

bcma/

bcma.c

2 lines

bcma_erom.c

21 lines

Diff 16027

View Options

sys/dev/bhnd/bcma/bcma.c