Page MenuHomeFreeBSD
Differential D51856

tests: Add some regression tests for copy_file_range()
ClosedPublic
Actions

Authored by markj on Sun, Aug 10, 4:50 PM.

Details

Reviewers
rmacklem
Commits
rG3af6f55735ce: tests: Add some regression tests for copy_file_range()
Summary

These cover a few bugs that have cropped up, including the ones fixed by
commits 4046ad6bb0e and 2319ca6a0181.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 66152
Build 63035: arc lint + arc unit

Event Timeline

markj created this revision.Sun, Aug 10, 4:50 PM
Herald added a subscriber: imp. · View Herald TranscriptSun, Aug 10, 4:50 PM
markj requested review of this revision.Sun, Aug 10, 4:50 PM
Harbormaster completed remote builds in B66152: Diff 160162.Sun, Aug 10, 4:50 PM
rmacklem accepted this revision.Mon, Aug 11, 3:23 PM

Looks good to me. Thanks for doing this, rick

tests/sys/kern/copy_file_range.c
99

Although setting the length to SIZE_MAX is allowed,
it is clipped to SSIZE_MAX. This is because the return value
is "len" and it is signed.

I don't know if this matters for your test, so just consider
this fyi.

This revision is now accepted and ready to land.Mon, Aug 11, 3:23 PM
markj marked an inline comment as done.Tue, Aug 12, 1:01 PM
markj added inline comments.
tests/sys/kern/copy_file_range.c
99

It doesn't matter for the test, I just forgot about the clamping. I fixed this in my local version, thanks.

Closed by commit rG3af6f55735ce: tests: Add some regression tests for copy_file_range() (authored by markj). · Explain WhyTue, Aug 12, 9:45 PM
This revision was automatically updated to reflect the committed changes.
markj marked an inline comment as done.
markj added a commit: rG3af6f55735ce: tests: Add some regression tests for copy_file_range().

Revision Contents
Changeset List

PathSize
tests/
sys/
kern/
2 lines
231 lines

Diff 160162

View Options

tests/sys/kern/Makefile

Loading...
View Options

tests/sys/kern/copy_file_range.c

Loading...