vfs: Put the definition of COPY_FILE_RANGE_CLONE in an appropriate place
ClosedPublic
Actions

Authored by rmacklem on Aug 9 2025, 1:11 AM.

Details

Reviewers

Commits

rG7a9834041c91: vfs: Put the definition of COPY_FILE_RANGE_CLONE in unistd.h

Summary

kib@ noted that having COPY_FILE_RANGE_CLONE defined
in vnode.h was inappropriate, since it is meant to be used from
user space as well as kernel space.

This patch moves it into sys/unistd.h and reverts the addition
of it in vnode.h.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rmacklem created this revision.Aug 9 2025, 1:11 AM

Herald added a subscriber: imp. · View Herald TranscriptAug 9 2025, 1:11 AM

rmacklem requested review of this revision.Aug 9 2025, 1:11 AM

kib accepted this revision.Aug 9 2025, 2:25 AM

kib added inline comments.

sys/sys/unistd.h
223	Why it matter which bits Linux uses?

This revision is now accepted and ready to land.Aug 9 2025, 2:25 AM

rmacklem added inline comments.Aug 9 2025, 2:31 AM

sys/sys/unistd.h
223	It doesn't matter a lot. I thought it might avoid confusion and simplify the Linuxolator implementation (it wouldn't have to map flags).

Closed by commit rG7a9834041c91: vfs: Put the definition of COPY_FILE_RANGE_CLONE in unistd.h (authored by rmacklem). · Explain WhyAug 9 2025, 8:37 PM

This revision was automatically updated to reflect the committed changes.

rmacklem added a commit: rG7a9834041c91: vfs: Put the definition of COPY_FILE_RANGE_CLONE in unistd.h.

Revision Contents
Changeset List

Path

Size

sys/

unistd.h

9 lines

vnode.h

17 lines

Diff 160136

View Options

sys/sys/unistd.h