Page MenuHomeFreeBSD
Differential D51776

find: Fix -printf
ClosedPublic
Actions

Authored by des on Wed, Aug 6, 10:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Aug 19, 7:37 PM
Unknown Object (File)
Tue, Aug 19, 6:48 PM
Unknown Object (File)
Tue, Aug 19, 6:40 PM
Unknown Object (File)
Tue, Aug 19, 6:36 PM
Unknown Object (File)
Tue, Aug 19, 6:14 PM
Unknown Object (File)
Tue, Aug 19, 6:09 PM
Unknown Object (File)
Tue, Aug 19, 4:25 PM
Unknown Object (File)
Tue, Aug 19, 10:33 AM
View All 9 Files
Subscribers
ziaee

Details

Reviewers
imp
Commits
rG02f394281fd6: find: Fix -printf
Summary

Each -printf invocation created a memstream, then freed the underlying
buffer without closing the stream, resulting in a segfault on exit
when libc tried to flush all the streams.

While here, simplify the implementation of %h.

Fixes: 7b9c912c41f4

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des requested review of this revision.Wed, Aug 6, 10:16 PM
des created this revision.
Harbormaster completed remote builds in B66044: Diff 159925.Wed, Aug 6, 10:16 PM
des edited the summary of this revision. (Show Details)Wed, Aug 6, 10:24 PM
des updated this revision to Diff 159927.Wed, Aug 6, 10:24 PM
des edited the summary of this revision. (Show Details)

drop memstream

Harbormaster completed remote builds in B66046: Diff 159927.Wed, Aug 6, 10:24 PM
des added a comment.Wed, Aug 6, 10:24 PM

We should also try to figure out a way to call escape() only once.

imp accepted this revision.Wed, Aug 6, 10:25 PM

This looks good. It matches what I have, plus fixes 'h'. So go ahead and test/commit it.

This revision is now accepted and ready to land.Wed, Aug 6, 10:25 PM
des edited the summary of this revision. (Show Details)Wed, Aug 6, 11:58 PM
des updated this revision to Diff 159932.Wed, Aug 6, 11:58 PM
des edited the summary of this revision. (Show Details)

more

This revision now requires review to proceed.Wed, Aug 6, 11:58 PM
Herald added a subscriber: ziaee. · View Herald TranscriptWed, Aug 6, 11:58 PM
Harbormaster completed remote builds in B66048: Diff 159932.Wed, Aug 6, 11:58 PM
imp accepted this revision.Thu, Aug 7, 1:07 AM
This revision is now accepted and ready to land.Thu, Aug 7, 1:07 AM
Closed by commit rG02f394281fd6: find: Fix -printf (authored by des). · Explain WhyThu, Aug 7, 1:26 AM
This revision was automatically updated to reflect the committed changes.
des added a commit: rG02f394281fd6: find: Fix -printf.

Revision Contents
Changeset List

PathSize
usr.bin/
find/
13 lines
161 lines
tests/
111 lines

Diff 159937

View Options

usr.bin/find/find.1

Loading...
View Options

usr.bin/find/printf.c

Loading...
View Options

usr.bin/find/tests/find_test.sh

Loading...