libthr: GC unused _sigsuspend()
ClosedPublic
Actions

Authored by brooks on Fri, Aug 1, 12:36 PM.

Tags

None

Referenced Files

	F126515631: D51670.diff
	Wed, Aug 20, 11:11 AM

	F126512510: D51670.id159848.diff
	Wed, Aug 20, 10:15 AM

	F126504364: D51670.id159543.diff
	Wed, Aug 20, 7:41 AM

	F126499274: D51670.id.diff
	Wed, Aug 20, 6:10 AM

	F126498757: D51670.id159555.diff
	Wed, Aug 20, 5:59 AM

	Unknown Object (File)
	Sat, Aug 16, 7:35 PM

	Unknown Object (File)
	Tue, Aug 12, 5:39 PM

	Unknown Object (File)
	Tue, Aug 12, 6:43 AM

View All 11 Files

Subscribers

imp

Details

Reviewers

kib

Commits

rG40a4508c4f90: libthr: GC unused _sigsuspend()

Summary

There are no consumers and it isn't a public symbol.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

brooks created this revision.Fri, Aug 1, 12:36 PM

Herald added a subscriber: imp. · View Herald TranscriptFri, Aug 1, 12:36 PM

brooks requested review of this revision.Fri, Aug 1, 12:36 PM

Harbormaster completed remote builds in B65884: Diff 159543.Fri, Aug 1, 12:37 PM

There is a '.globl _sigsuspend' in thr_init.c generated through STATIC_LIB_REQUIRE. It probably should be removed as well.

lib/libthr/thread/thr_sig.c
705	I suspect this line was expected to use _sigsuspend() but then I decided to be explicit.

Remove attempt to resolve _sigsuspend() from thr_init.c

Harbormaster completed remote builds in B65889: Diff 159555.Fri, Aug 1, 1:24 PM

kib accepted this revision.Fri, Aug 1, 2:57 PM

This revision is now accepted and ready to land.Fri, Aug 1, 2:57 PM

Closed by commit rG40a4508c4f90: libthr: GC unused _sigsuspend() (authored by brooks). · Explain WhyWed, Aug 6, 12:52 PM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rG40a4508c4f90: libthr: GC unused _sigsuspend().

Revision Contents
Changeset List

Path

Size

lib/

libthr/

thread/

thr_init.c

1 line

thr_sig.c

8 lines

Diff 159848

View Options

lib/libthr/thread/thr_init.c