Page MenuHomeFreeBSD

libc: stop trying to create __<syscall> symbols
ClosedPublic

Authored by brooks on Aug 1 2025, 12:35 PM.
Tags
None
Referenced Files
F170643706: D51668.diff
Sat, Sep 5, 7:00 PM
Unknown Object (File)
Sat, Sep 5, 1:31 PM
Unknown Object (File)
Thu, Sep 3, 2:01 PM
Unknown Object (File)
Tue, Sep 1, 1:58 PM
Unknown Object (File)
Tue, Sep 1, 11:31 AM
Unknown Object (File)
Tue, Sep 1, 3:53 AM
Unknown Object (File)
Mon, Aug 31, 7:36 PM
Unknown Object (File)
Mon, Aug 31, 4:34 AM
Subscribers

Details

Summary

When we switched to an interposing table (commit 8495e8b1e9e1) for
cancelation points we stopped having concrete implementations of
<syscall> and instead use sys_<syscall> and __thr_<syscall>.
These entries of the form:

weak_reference(sys_<syscall>, __<syscall>);

seem to be intended to preserve these symbols, but they have no effect
as __sys_<syscall> isn't defined in the translation units in question.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I have half a memory of this pattern being added to the mix as a compat bridge when moving away from libcR... but it's clear they'd have no effect now

This revision is now accepted and ready to land.Aug 1 2025, 5:50 PM