Page MenuHomeFreeBSD

libc: stop trying to create __<syscall> symbols
ClosedPublic

Authored by brooks on Aug 1 2025, 12:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 15, 11:11 AM
Unknown Object (File)
Mon, Oct 27, 8:38 PM
Unknown Object (File)
Oct 25 2025, 2:59 AM
Unknown Object (File)
Oct 23 2025, 3:12 AM
Unknown Object (File)
Oct 14 2025, 3:13 AM
Unknown Object (File)
Oct 12 2025, 2:50 PM
Unknown Object (File)
Oct 12 2025, 3:40 AM
Unknown Object (File)
Oct 12 2025, 3:40 AM
Subscribers

Details

Summary

When we switched to an interposing table (commit 8495e8b1e9e1) for
cancelation points we stopped having concrete implementations of
<syscall> and instead use sys_<syscall> and __thr_<syscall>.
These entries of the form:

weak_reference(sys_<syscall>, __<syscall>);

seem to be intended to preserve these symbols, but they have no effect
as __sys_<syscall> isn't defined in the translation units in question.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I have half a memory of this pattern being added to the mix as a compat bridge when moving away from libcR... but it's clear they'd have no effect now

This revision is now accepted and ready to land.Aug 1 2025, 5:50 PM