Page MenuHomeFreeBSD
Differential D51695

[phb][security]: Create VuXML checklist
ClosedPublic
Actions

Authored by fernape on Sat, Aug 2, 12:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Aug 18, 10:54 PM
Unknown Object (File)
Thu, Aug 14, 5:38 PM
Unknown Object (File)
Thu, Aug 14, 2:39 PM
Subscribers
bcr

Details

Reviewers
mandree
bcr
Group Reviewers
Doc Committers
ports secteam
Commits
R9:df2914ac4a93: [phb][security]: Create VuXML checklist
Summary

Create a short checklist with some important points to check before committing.
Prompted by a mail by mandree@.

Test Plan

Apply patch, make run in the documentation/ directory and go to localhost:1313 to inspect the result.

Diff Detail

Repository
R9 FreeBSD doc repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 65925
Build 62808: arc lint + arc unit

Event Timeline

fernape requested review of this revision.Sat, Aug 2, 12:16 PM
fernape created this revision.
Harbormaster completed remote builds in B65914: Diff 159621.Sat, Aug 2, 12:16 PM
fernape edited the test plan for this revision. (Show Details)Sat, Aug 2, 12:18 PM
fernape added reviewers: Doc Committers, ports secteam, mandree.
bcr added a subscriber: bcr.Sat, Aug 2, 1:02 PM

A few minor textual suggestions.

documentation/content/en/books/porters-handbook/security/_index.adoc
326

How about active voice here:
Use the following script to generate ...

335

s/can help/helps/

347

s/instance package:/instance, package:/

fernape updated this revision to Diff 159636.Sat, Aug 2, 4:49 PM

Address bcr@ feedback

Harbormaster completed remote builds in B65925: Diff 159636.Sat, Aug 2, 4:49 PM
fernape marked 3 inline comments as done.Sat, Aug 2, 4:50 PM
bcr accepted this revision as: bcr.Sat, Aug 2, 5:22 PM

Looks good now, thank you!

This revision is now accepted and ready to land.Sat, Aug 2, 5:22 PM
fernape added a comment.Sun, Aug 3, 11:05 AM

Thanks for the review!

Closed by commit R9:df2914ac4a93: [phb][security]: Create VuXML checklist (authored by fernape). · Explain WhySun, Aug 3, 11:10 AM
This revision was automatically updated to reflect the committed changes.
fernape added a commit: R9:df2914ac4a93: [phb][security]: Create VuXML checklist.

Revision Contents
Changeset List

PathSize
documentation/
content/
en/
books/
porters-handbook/
security/
35 lines

Diff 159636

View Options

documentation/content/en/books/porters-handbook/security/_index.adoc

Loading...