Differential D51670

libthr: GC unused _sigsuspend()
ClosedPublic
Actions

Authored by brooks on Aug 1 2025, 12:36 PM.

Details

Reviewers

kib

Commits

rG40a4508c4f90: libthr: GC unused _sigsuspend()

Summary

There are no consumers and it isn't a public symbol.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 65889
Build 62772: arc lint + arc unit

Event Timeline

brooks created this revision.Aug 1 2025, 12:36 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 1 2025, 12:36 PM

brooks requested review of this revision.Aug 1 2025, 12:36 PM

Harbormaster completed remote builds in B65884: Diff 159543.Aug 1 2025, 12:37 PM

There is a '.globl _sigsuspend' in thr_init.c generated through STATIC_LIB_REQUIRE. It probably should be removed as well.

lib/libthr/thread/thr_sig.c
705	I suspect this line was expected to use _sigsuspend() but then I decided to be explicit.

Remove attempt to resolve _sigsuspend() from thr_init.c

Harbormaster completed remote builds in B65889: Diff 159555.Aug 1 2025, 1:24 PM

kib accepted this revision.Aug 1 2025, 2:57 PM

This revision is now accepted and ready to land.Aug 1 2025, 2:57 PM

Closed by commit rG40a4508c4f90: libthr: GC unused _sigsuspend() (authored by brooks). · Explain WhyAug 6 2025, 12:52 PM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rG40a4508c4f90: libthr: GC unused _sigsuspend().

Revision Contents
Changeset List

Path

Size

lib/

libthr/

thread/

thr_init.c

1 line

thr_sig.c

8 lines

Diff 159555

View Options

lib/libthr/thread/thr_init.c