bsnmp: wlan: use correct value for rssi
ClosedPublic
Actions

Authored by bz on Jun 19 2025, 1:28 AM.

Details

Reviewers

harti
emaste

Group Reviewers

wireless

Commits

rG69ffe3a6e778: bsnmp: wlan: use correct value for rssi

Summary

net80211 keeps the rssi value in 0.5bm relative to the noise floor
(see comment in ieee80211_node.h). Do proper maths to get a plain
rssi value back (*).

(*) Not quite yet but that's a general problem throughout the stack.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bz created this revision.Jun 19 2025, 1:28 AM

Herald added a subscriber: imp. · View Herald TranscriptJun 19 2025, 1:28 AM

bz requested review of this revision.Jun 19 2025, 1:28 AM

Harbormaster completed remote builds in B64972: Diff 157295.Jun 19 2025, 1:28 AM

bz added a reviewer: harti.Mon, Jul 28, 2:20 AM

(*) Not quite yet but that's a general problem throughout the stack.

IOW we're just making bsnmp consistent with RSSI reporting elsewhere, OK. I guess another thing for us to add to our Wi-Fi tech debt list.

This revision is now accepted and ready to land.Mon, Jul 28, 6:03 PM

In D50930#1178595, @emaste wrote:

(*) Not quite yet but that's a general problem throughout the stack.

IOW we're just making bsnmp consistent with RSSI reporting elsewhere, OK. I guess another thing for us to add to our Wi-Fi tech debt list.

See https://reviews.freebsd.org/D50928 but I by now think we should try to keep an original signal value (or multiple) if avail and then keep noise along, and leave rssi on the side. But that's for there and I should update that review.

Closed by commit rG69ffe3a6e778: bsnmp: wlan: use correct value for rssi (authored by bz). · Explain WhyThu, Jul 31, 5:44 PM

This revision was automatically updated to reflect the committed changes.

bz added a commit: rG69ffe3a6e778: bsnmp: wlan: use correct value for rssi.