dbm_nextkey: Always return an error if we've reached the end of the database
ClosedPublic
Actions

Authored by bnovkov on Jul 30 2025, 2:57 PM.

Details

Reviewers

markj

Group Reviewers

Klara

Commits

rG3a686b851f8f: dbm_nextkey: Always return an error if we've reached the end of the database

Summary

POSIX.1 states that dbm_nextkey must return an invalid key
(i.e., key.dptr == NULL) after the end of the database was reached.
The current implementation of hash_seq will incorrectly restart
the key sequence after the end of the database is reached.

Fix this by checking the "current bucket" index when R_NEXT is passed.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

bnovkov created this revision.Jul 30 2025, 2:57 PM

Herald added a subscriber: imp. · View Herald TranscriptJul 30 2025, 2:57 PM

bnovkov requested review of this revision.Jul 30 2025, 2:57 PM

Harbormaster completed remote builds in B65848: Diff 159445.Jul 30 2025, 2:57 PM

Remove stray newline.

markj added a subscriber: markj.Jul 31 2025, 2:03 PM

markj added inline comments.

lib/libc/db/hash/hash.c
718	Is it legal to call this routine with `flag == 0`? The check above suggests so, but within libc there are no such calls. Are consumers allowed to call `db->seq()` directly?