Page MenuHomeFreeBSD
Differential D51332

Provide more context in github pull request issue comment
ClosedPublic
Actions

Authored by emaste on Tue, Jul 15, 6:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jul 28, 9:37 PM
Unknown Object (File)
Mon, Jul 28, 4:35 PM
Unknown Object (File)
Mon, Jul 28, 2:31 PM
Unknown Object (File)
Mon, Jul 28, 2:30 PM
Unknown Object (File)
Mon, Jul 28, 12:28 AM
Unknown Object (File)
Sun, Jul 27, 11:29 PM
Unknown Object (File)
Sun, Jul 27, 11:14 PM
Unknown Object (File)
Sun, Jul 27, 9:57 PM
View All 15 Files
Subscribers
ziaee

Details

Reviewers
imp
Group Reviewers
srcmgr
Commits
rGf38ac6f27ace: GitHub: Provide more context in pull request issue comment

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste requested review of this revision.Tue, Jul 15, 6:13 PM
emaste created this revision.
imp accepted this revision as: imp.Tue, Jul 15, 8:27 PM
This revision is now accepted and ready to land.Tue, Jul 15, 8:27 PM
ziaee added a subscriber: ziaee.Tue, Jul 15, 9:13 PM

Pushing the updated branch will update the pull request, so maybe that bit is redundant?

ziaee added inline comments.Wed, Jul 16, 2:29 PM
.github/workflows/checklist.yml
92

Maybe clearer for noobs? I know when I started sending patches I didn't know how to use git.

emaste added inline comments.Wed, Jul 16, 2:32 PM
.github/workflows/checklist.yml
92

Yeah, I wanted to capture that the author needs to fix up their commit(s) locally, and subsequently the GH pull request. I think your update is a bit more explicit and will incorporate it.

Closed by commit rGf38ac6f27ace: GitHub: Provide more context in pull request issue comment (authored by emaste). · Explain WhyWed, Jul 16, 2:49 PM
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rGf38ac6f27ace: GitHub: Provide more context in pull request issue comment.

Revision Contents
Changeset List

PathSize
.github/
workflows/
1 line

Diff 158605

View Options

.github/workflows/checklist.yml

Loading...