Differential D51343

libc: Test time zone change detection.
ClosedPublic
Actions

Authored by des on Wed, Jul 16, 1:28 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Aug 4, 10:05 AM

	Unknown Object (File)
	Sat, Aug 2, 6:57 AM

	Unknown Object (File)
	Mon, Jul 28, 6:55 PM

	Unknown Object (File)
	Mon, Jul 28, 3:06 PM

	Unknown Object (File)
	Mon, Jul 28, 2:55 PM

	Unknown Object (File)
	Mon, Jul 28, 3:39 AM

	Unknown Object (File)
	Mon, Jul 28, 3:36 AM

	Unknown Object (File)
	Mon, Jul 28, 12:14 AM

View All 29 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG57ee56578cc5: libc: Test time zone change detection.

Summary

Sponsored by: Klara, Inc.
Sponsored by: NetApp, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 65481
Build 62364: arc lint + arc unit

Event Timeline

des created this revision.Wed, Jul 16, 1:28 PM

Herald added a subscriber: imp. · View Herald TranscriptWed, Jul 16, 1:28 PM

des requested review of this revision.Wed, Jul 16, 1:28 PM

Harbormaster completed remote builds in B65481: Diff 158599.Wed, Jul 16, 1:28 PM

nits

Harbormaster completed remote builds in B65484: Diff 158604.Wed, Jul 16, 2:49 PM

tzset is unnecessary and may slow the test down

Harbormaster completed remote builds in B65488: Diff 158616.Wed, Jul 16, 4:25 PM

more cleanup

Harbormaster completed remote builds in B65509: Diff 158660.Thu, Jul 17, 12:59 PM

markj added a subscriber: markj.Thu, Jul 17, 2:58 PM

markj added inline comments.

contrib/tzcode/localtime.c
414	Is this bringing us closer to upstream's code?
lib/libc/tests/stdtime/detect_tz_changes_test.c
56	Probably not much of an issue in practice, but I believe copy_file_range() must be called in a loop to handle short I/O.
153	I believe ATF_* can't be used in a child process.

des marked 3 inline comments as done.Thu, Jul 17, 6:21 PM

des added inline comments.

contrib/tzcode/localtime.c
414	No, this code does not exist upstream.
lib/libc/tests/stdtime/detect_tz_changes_test.c
153	It works just fine. It emits an error message to stderr (which we echo) and kills the child (which causes the parent to fail).

des marked 2 inline comments as done.Fri, Jul 18, 9:03 AM

des added inline comments.

contrib/tzcode/localtime.c
519	This actually fixes a regression in bc42155199b5. I'll split it out into a separate commit.

rebase

Harbormaster completed remote builds in B65555: Diff 158730.Fri, Jul 18, 10:06 AM

des added a parent revision: D51405: tzcode: Fix time zone change detection..Fri, Jul 18, 10:06 AM

markj accepted this revision as: markj.Fri, Jul 18, 4:16 PM

This revision is now accepted and ready to land.Fri, Jul 18, 4:16 PM

Closed by commit rG57ee56578cc5: libc: Test time zone change detection. (authored by des). · Explain WhyFri, Jul 18, 5:52 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG57ee56578cc5: libc: Test time zone change detection..

Revision Contents
Changeset List

Path

Size

contrib/

tzcode/

3 lines

lib/

libc/

stdtime/

1 line

6 lines

tests/

stdtime/

5 lines

detect_tz_changes_test.c

276 lines

Diff 158599

contrib/tzcode/localtime.c

Loading...

lib/libc/stdtime/Makefile.inc

Loading...

lib/libc/stdtime/Symbol.map

Loading...

lib/libc/tests/stdtime/Makefile

Loading...

lib/libc/tests/stdtime/detect_tz_changes_test.c

Loading...