Page MenuHomeFreeBSD
Differential D51319

fdescfs: Set *eofflag in fdesc_readdir()
ClosedPublic
Actions

Authored by markj on Jul 15 2025, 12:38 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Aug 31, 1:18 PM
Unknown Object (File)
Tue, Aug 25, 11:45 PM
Unknown Object (File)
Wed, Aug 19, 8:23 PM
Unknown Object (File)
Fri, Aug 14, 8:11 PM
Unknown Object (File)
Mon, Aug 10, 8:51 PM
Unknown Object (File)
Aug 10 2026, 6:01 PM
Unknown Object (File)
Aug 10 2026, 8:51 AM
Unknown Object (File)
Aug 9 2026, 7:36 PM
View All 87 Files
Subscribers
imp

Details

Reviewers
kib
Commits
rGd8ef477a7bfe: fdescfs: Set *eofflag in fdesc_readdir()
rGda84054f3a50: fdescfs: Set *eofflag in fdesc_readdir()

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 65442
Build 62325: arc lint + arc unit

Event Timeline

markj created this revision.Jul 15 2025, 12:38 AM
Herald added a subscriber: imp. · View Herald TranscriptJul 15 2025, 12:38 AM
markj requested review of this revision.Jul 15 2025, 12:38 AM
Harbormaster completed remote builds in B65442: Diff 158514.Jul 15 2025, 12:38 AM
kib added inline comments.Jul 15 2025, 12:42 AM
sys/fs/fdescfs/fdesc_vnops.c
564

Might be write this without duplication?

while (uio->uio_resid >= UIO_MX) {
     if (i >= fdp->fd_nfiles + 2) {
           if (ap->a_eofflag != NULL)
             *ap->a_eofflag = 1;
          break;
    }
markj updated this revision to Diff 158516.Jul 15 2025, 12:45 AM
markj marked an inline comment as done.

Deduplicate

Harbormaster completed remote builds in B65443: Diff 158516.Jul 15 2025, 12:45 AM
kib accepted this revision.Jul 15 2025, 12:49 AM
This revision is now accepted and ready to land.Jul 15 2025, 12:49 AM
Closed by commit rGda84054f3a50: fdescfs: Set *eofflag in fdesc_readdir() (authored by markj). · Explain WhyJul 15 2025, 12:53 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rGda84054f3a50: fdescfs: Set *eofflag in fdesc_readdir().
markj added a commit: rGd8ef477a7bfe: fdescfs: Set *eofflag in fdesc_readdir().Jul 29 2025, 5:41 PM

Revision Contents
Changeset List

PathSize
sys/
fs/
fdescfs/
4 lines

Diff 158514

View Options

sys/fs/fdescfs/fdesc_vnops.c

Loading...