net-mgmt/gnu-ipcalc: Don't abuse DOCS for MANPAGES
ClosedPublic
Actions

Authored by michaelo on Tue, Jun 24, 5:51 PM.

Details

Reviewers

jrm
otis
ehaupt
diizzy

Commits

R11:bd3beda0b31c: net-mgmt/gnu-ipcalc: Don't abuse DOCS for MANPAGES

Summary

PR: 287652
Approved by: jrm (mentor), otis (mentor), ehaupt (maintainer)

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 65076
Build 61959: arc lint + arc unit

Event Timeline

michaelo requested review of this revision.Tue, Jun 24, 5:51 PM

michaelo created this revision.

Harbormaster completed remote builds in B65061: Diff 157536.Tue, Jun 24, 5:51 PM

lgtm,
While out of scope you should be able to remove GL_TAGNAME and replace PORTVERSION with DISTVERSION

michaelo added a reviewer: diizzy.Tue, Jun 24, 7:22 PM

Simplify Makefile

Harbormaster completed remote builds in B65062: Diff 157539.Tue, Jun 24, 7:32 PM

The current version does not fetch. If you insist on removing the GL_ stuff (though I don't see the point—aside from dizzy fighting his personal war against convenient git references), please test with make distclean; make fetch. Also, please run portfmt -i on the Makefile.

This revision now requires changes to proceed.Tue, Jun 24, 7:55 PM

In D51019#1164454, @ehaupt wrote:

The current version does not fetch. If you insist on removing the GL_ stuff (though I don't see the point—aside from dizzy fighting his personal war against convenient git references), please test with make distclean; make fetch. Also, please run portfmt -i on the Makefile.

Removing both GL_ACCOUNT and GL_TAGNAME will for sure break, GL_TAGNAME isn't necessary as of https://cgit.freebsd.org/ports/commit/Mk/bsd.sites.mk?id=16bde072b16daca1c886116e602c94b5fa99c20f

Run portfmt -i Makefile

Harbormaster completed remote builds in B65076: Diff 157575.Wed, Jun 25, 4:59 AM

In D51019#1164454, @ehaupt wrote:

The current version does not fetch. If you insist on removing the GL_ stuff (though I don't see the point—aside from dizzy fighting his personal war against convenient git references), please test with make distclean; make fetch. Also, please run portfmt -i on the Makefile.

Works for me:

osipovmi@deblndw011x:~/var/Projekte/freebsd/ports/net-mgmt/gnu-ipcalc (docs-to-manpages-gnu-ipcalc =)
$ make distclean
===>  Cleaning for gnu-ipcalc-1.0.3_2
===>  Deleting distfiles for gnu-ipcalc-1.0.3_2
osipovmi@deblndw011x:~/var/Projekte/freebsd/ports/net-mgmt/gnu-ipcalc (docs-to-manpages-gnu-ipcalc =)
$ make fetch
===>  License GPLv2 accepted by the user
===>   gnu-ipcalc-1.0.3_2 depends on file: /usr/local/sbin/pkg - found
=> ipcalc-1.0.3.tar.bz2 doesn't seem to exist in /var/osipovmi/Projekte/freebsd/ports/distfiles/.
=> Attempting to fetch https://gitlab.com/ipcalc/ipcalc/-/archive/1.0.3/ipcalc-1.0.3.tar.bz2
fetch: https://gitlab.com/ipcalc/ipcalc/-/archive/1.0.3/ipcalc-1.0.3.tar.bz2: size unknown
fetch: https://gitlab.com/ipcalc/ipcalc/-/archive/1.0.3/ipcalc-1.0.3.tar.bz2: size of remote file is not known
ipcalc-1.0.3.tar.bz2                                    45 kB   17 MBps    00s
===> Fetching all distfiles required by gnu-ipcalc-1.0.3_2 for building

See bsd.sites.mk both GL_ACCOUNT and GL_PROJECT point to ${PORTNAME}.