Page MenuHomeFreeBSD

www/neon: Don't abuse DOCS for MANPAGES
AcceptedPublic

Authored by michaelo on Tue, Jun 24, 5:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jul 8, 4:59 AM
Unknown Object (File)
Sat, Jul 5, 2:04 AM
Unknown Object (File)
Thu, Jul 3, 9:02 PM
Subscribers

Details

Reviewers
jrm
otis
lev
diizzy
Summary

Drop also DOCS dependencies because they come procompiled with the dist file.

PR: 287652
Approved by: jrm (mentor), otis (mentor), lev (maintainer)

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 65057
Build 61940: arc lint + arc unit

Event Timeline

michaelo created this revision.

To be fair I'd argue for that unless there a switch/toggle provided by upstream we always install manpages unless they have dependencies.

To be fair I'd argue for that unless there a switch/toggle provided by upstream we always install manpages unless they dependencies.

I see your point, but I would counter with:

  • In the ports tree there is a split, I'd prefer to stay consistent and maybe in production deploy setups people even don't need manpages at all.
  • Not everyone needs the docs, but wants manpages. Especially on servers I consider docs as useless. Best example: lang/rust.

I wonder to what degree @lev is still active because back then I took over all of this Subversion-related ports. Anyone else?

I'd value consistency over granuality that adds complexity but that's a personal opinion. If it works and Poudriere is happy I don't have any objections. Mentors?

I'd value consistency over granuality that adds complexity but that's a personal opinion. If it works and Poudriere is happy I don't have any objections. Mentors?

Tried all combos before creating the review...

I also lean towards always installing man pages, unless there is some obscene dependency or an upstream toggle. I can also appreciate the value in providing the option.

This revision is now accepted and ready to land.Sun, Jun 29, 8:34 PM
In D51016#1166054, @jrm wrote:

I also lean towards always installing man pages, unless there is some obscene dependency or an upstream toggle. I can also appreciate the value in providing the option.

There are cases where pandoc is required for manpages which requires ghc, etc. Quite some dependency tree. Best counterexample for docs is rust: 80% docs, 20% rust.

No maintainer response, can we use timeout here?