Page MenuHomeFreeBSD
Differential D50984

cp: Fix improper use of O_PATH.
ClosedPublic
Actions

Authored by des on Mon, Jun 23, 8:23 PM.
Tags
None
Referenced Files
F122391200: D50984.diff
Fri, Jul 4, 10:42 PM
Unknown Object (File)
Fri, Jun 27, 3:41 PM
Unknown Object (File)
Fri, Jun 27, 3:41 PM
Unknown Object (File)
Fri, Jun 27, 3:41 PM
Unknown Object (File)
Fri, Jun 27, 3:41 PM
Unknown Object (File)
Fri, Jun 27, 3:41 PM
Unknown Object (File)
Tue, Jun 24, 9:47 PM
Unknown Object (File)
Tue, Jun 24, 9:22 PM
View All 12 Files
Subscribers
imp

Details

Reviewers
kevans
Group Reviewers
Klara
Commits
rG0e0df1fc6753: cp: Fix improper use of O_PATH.
Summary

This does not appear to make any practical difference at the moment, but
technically O_PATH means “I'm not going to use this descriptor for any
other purposes than vnode lookups”, so using it to read the directory's
ACLs is improper and might fail in the future.

Fixes: 82fc0d09e8625
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 65033
Build 61916: arc lint + arc unit

Revision Contents
Changeset List

PathSize
bin/
cp/
tests/
18 lines
2 lines

Diff 157465

View Options

bin/cp/tests/cp_test.sh

Loading...
View Options

bin/cp/utils.c

Loading...