Paths

Table of Contentst

Differential D50984

cp: Fix improper use of O_PATH.
ClosedPublic
Actions

Authored by des on Mon, Jun 23, 8:23 PM.

Tags

None

Referenced Files

	F122648908: D50984.id.diff
	Mon, Jul 7, 3:13 AM

	Unknown Object (File)
	Sun, Jul 6, 3:29 AM

	Unknown Object (File)
	Fri, Jul 4, 10:42 PM

	Unknown Object (File)
	Fri, Jun 27, 3:41 PM

	Unknown Object (File)
	Fri, Jun 27, 3:41 PM

	Unknown Object (File)
	Fri, Jun 27, 3:41 PM

	Unknown Object (File)
	Fri, Jun 27, 3:41 PM

	Unknown Object (File)
	Fri, Jun 27, 3:41 PM

View All 14 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG0e0df1fc6753: cp: Fix improper use of O_PATH.

Summary

This does not appear to make any practical difference at the moment, but
technically O_PATH means “I'm not going to use this descriptor for any
other purposes than vnode lookups”, so using it to read the directory's
ACLs is improper and might fail in the future.

Fixes: 82fc0d09e8625
Sponsored by: Klara, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 65032
Build 61915: arc lint + arc unit

Event Timeline

des created this revision.Mon, Jun 23, 8:23 PM

Herald added a subscriber: imp. · View Herald TranscriptMon, Jun 23, 8:23 PM

des requested review of this revision.Mon, Jun 23, 8:23 PM

Harbormaster completed remote builds in B65032: Diff 157464.Mon, Jun 23, 8:23 PM

O_SEARCH -> O_RDONLY

Harbormaster completed remote builds in B65033: Diff 157465.Mon, Jun 23, 8:32 PM

kevans accepted this revision.Mon, Jun 23, 8:33 PM

This revision is now accepted and ready to land.Mon, Jun 23, 8:33 PM

Closed by commit rG0e0df1fc6753: cp: Fix improper use of O_PATH. (authored by des). · Explain WhyMon, Jun 23, 8:39 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG0e0df1fc6753: cp: Fix improper use of O_PATH..

Revision Contents
Changeset List

Path

Size

bin/

cp/

tests/

18 lines

2 lines

Diff 157464

bin/cp/tests/cp_test.sh

Loading...

bin/cp/utils.c

Loading...