Page MenuHomeFreeBSD
Differential D6124

net80211: provide a set of ieee80211_add_channel*() functions
ClosedPublic
Actions

Authored by avos on Apr 27 2016, 2:32 PM.
Tags
None
Referenced Files
F105773238: D6124.id15743.diff
Fri, Dec 20, 12:17 PM
Unknown Object (File)
Wed, Dec 11, 7:06 AM
Unknown Object (File)
Sun, Dec 8, 5:50 PM
Unknown Object (File)
Tue, Dec 3, 8:39 AM
Unknown Object (File)
Oct 21 2024, 7:16 AM
Unknown Object (File)
Oct 21 2024, 7:16 AM
Unknown Object (File)
Oct 21 2024, 7:15 AM
Unknown Object (File)
Oct 21 2024, 6:47 AM
View All 83 Files
Subscribers
imp

Details

Reviewers
adrian
Commits
rS298812: net80211: provide a set of ieee80211_add_channel*() functions
Summary

This diff adds few methods for net80211 channel table setup:

  • ieee80211_add_channel()
  • ieee80211_add_channel_ht40()

(primarily for drivers, that parse EEPROM to get channel list)

  • ieee80211_add_channel_list_2ghz()
  • ieee80211_add_channel_list_5ghz()

(mostly as a replacement for ieee80211_init_channels(); may be used in ic_getradiocaps())

TODO: reduce number of parameters (6 - 8 at this time).

Test Plan

Tested with wpi(4) (add_channel) and rum(4) (add_channel_list_2ghz).

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

avos updated this revision to Diff 15653.Apr 27 2016, 2:32 PM
avos retitled this revision from to net80211: provide a set of ieee80211_add_channel*() functions.
avos updated this object.
avos edited the test plan for this revision. (Show Details)
avos added a reviewer: adrian.
avos set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a subscriber: imp. · View Herald TranscriptApr 27 2016, 2:32 PM
avos added a child revision: D6125: rum: switch to ieee80211_add_channel_list_*().Apr 27 2016, 3:01 PM
adrian edited edge metadata.Apr 27 2016, 5:26 PM

ok, get some more testing of this (including ath(4), which does bad things to channel setup, iirc) and then i'll okay it. It looks fine as a first pass though, so thanks!

And this refactor also makes it easier to add VHT20/40/80 channel support when it comes time to do that.

avos mentioned this in D6139: ath: refactor/split getchannels() method.Apr 28 2016, 3:45 PM
avos added a child revision: D6140: bwn: switch to ieee80211_add_channel().Apr 28 2016, 4:19 PM
avos added a child revision: D6141: iwn: switch to ieee80211_add_channel*().Apr 28 2016, 6:34 PM
avos added a child revision: D6143: mwl: switch to ieee80211_add_channel*().Apr 28 2016, 7:01 PM
avos added a child revision: D6144: run: switch to ieee80211_add_channel_list_*().Apr 28 2016, 8:06 PM
avos added a child revision: D6145: otus: switch to ieee80211_add_channel_list_*().Apr 28 2016, 9:42 PM
adrian accepted this revision.Apr 29 2016, 2:14 AM
adrian edited edge metadata.
This revision is now accepted and ready to land.Apr 29 2016, 2:14 AM
Closed by commit rS298812: net80211: provide a set of ieee80211_add_channel*() functions (authored by avos). · Explain WhyApr 29 2016, 9:18 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
net80211/
264 lines
112 lines
8 lines

Diff 15743

View Options

head/sys/net80211/ieee80211.c

Loading...
View Options

head/sys/net80211/ieee80211_regdomain.c

Loading...
View Options

head/sys/net80211/ieee80211_var.h

Loading...