Page MenuHomeFreeBSD

otus: switch to ieee80211_add_channel_list_*()
ClosedPublic

Authored by avos on Apr 28 2016, 9:42 PM.
Tags
None
Referenced Files
F157408858: D6145.diff
Thu, May 21, 2:14 AM
Unknown Object (File)
Mon, May 18, 10:19 AM
Unknown Object (File)
Mon, May 18, 3:41 AM
Unknown Object (File)
Sun, May 17, 5:51 PM
Unknown Object (File)
Thu, May 14, 5:20 PM
Unknown Object (File)
Fri, May 8, 7:38 AM
Unknown Object (File)
Thu, May 7, 3:10 PM
Unknown Object (File)
Apr 17 2026, 7:34 AM
Subscribers

Details

Summary
  • Use device's channel list instead of default one (from ieee80211_init_channels()).
  • Sort channels (ieee80211_add_channel_list_* requirement).
  • Add ic_getradiocaps() method.
Test Plan

Needs testing.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

avos retitled this revision from to otus: switch to ieee80211_add_channel_list_*().
avos updated this object.
avos edited the test plan for this revision. (Show Details)
avos added a reviewer: adrian.
avos set the repository for this revision to rS FreeBSD src repository - subversion.
adrian edited edge metadata.
adrian added inline comments.
sys/dev/otus/if_otus.c
832 ↗(On Diff #15716)

Do you need to memset() on bands first before doing the 11n bands?

This revision is now accepted and ready to land.Apr 30 2016, 12:28 AM
sys/dev/otus/if_otus.c
832 ↗(On Diff #15716)

Not for add_channel_list (there is two (2ghz and 5ghz) methods for init_channels() compatibility - which accepts 'const uint8_t bands[]' array)
Ideally it should be like 'add_channel*(..., IEEE80211_MODE_11B | IEEE80211_MODE_11G)'; however, modes are enum, not bitmask.

sys/dev/otus/if_otus.c
832 ↗(On Diff #15716)

The above is right for 5ghz & 2ghz bits; for 11n you should just set MODE_11NG (or MODE_11NA) bit.

This revision was automatically updated to reflect the committed changes.