Differential D6150

iwm: switch to ieee80211_add_channel()
ClosedPublic
Actions

Authored by avos on Apr 29 2016, 3:49 PM.

Details

Reviewers

adrian

Commits

rS298877: iwm: switch to ieee80211_add_channel()

Summary

Switch to ieee80211_add_channel().
Parse/set more channel flags (DFS, NOADHOC).
Add ic_getradiocaps() method.

Test Plan

Needs testing (ifconfig wlan0 create wlandev iwm0 up && ifconfig wlan0 list chan; the output should not differ).

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

avos updated this revision to Diff 15735.Apr 29 2016, 3:49 PM

avos retitled this revision from to iwm: switch to ieee80211_add_channel().

avos updated this object.

avos edited the test plan for this revision. (Show Details)

avos added a reviewer: adrian.

avos set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptApr 29 2016, 3:49 PM

adrian added inline comments.Apr 29 2016, 4:03 PM

sys/dev/iwm/if_iwmvar.h
200	We should use a #define size or something here, otherwise when we move to 11n /someone/ will forget to bump it. :-P

avos added inline comments.Apr 29 2016, 4:10 PM

sys/dev/iwm/if_iwmvar.h
200	maybe, I should put iwm_nvm_channels[] somewhere in if_iwmreg.h (and use it size here directly)?

If you do that then it'll likely just get duplicated in each file that includes that .h file.

Just put a _MAX define somewhere, and a compile-time assert in if_iwm.c that the #define is = or larger than the set size. That'll at least fail compilation if someone ups the number of channel entries when we do 11n/11ac.

Refresh.

avos marked 2 inline comments as done.Apr 29 2016, 11:36 PM

avos added inline comments.

sys/dev/iwm/if_iwm.c
1734	iwlwifi doesn't enforce this limitation - probably, this (and other limitations) should be set by ieee80211_regdomain(9) (not used right now (except IEEE80211_IOC_REGDOMAIN ioctl)).

looks good, I'll update tonight when you've committed it and report back.

This revision is now accepted and ready to land.Apr 30 2016, 12:25 AM

Closed by commit rS298877: iwm: switch to ieee80211_add_channel() (authored by avos). · Explain WhyMay 1 2016, 2:27 PM

This revision was automatically updated to reflect the committed changes.

avos added inline comments.May 1 2016, 2:43 PM

head/sys/dev/iwm/if_iwm.c
175 ↗	(On Diff #15789)	CTASSERT(9) manpage states that 'The CTASSERT() macro is deprecated and the C11 standard _Static_assert() should be used instead' - so I've replaced CTASSERT() with _Static_assert. No other changes were done.