- Switch to ieee80211_add_channel().
- Parse/set more channel flags (DFS, NOADHOC).
- Add ic_getradiocaps() method.
Details
- Reviewers
- adrian 
- Commits
- rS298877: iwm: switch to ieee80211_add_channel()
Needs testing (ifconfig wlan0 create wlandev iwm0 up && ifconfig wlan0 list chan; the output should not differ).
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
- Lint Skipped 
- Unit
- Tests Skipped 
Event Timeline
| sys/dev/iwm/if_iwmvar.h | ||
|---|---|---|
| 200 | We should use a #define size or something here, otherwise when we move to 11n /someone/ will forget to bump it. :-P | |
| sys/dev/iwm/if_iwmvar.h | ||
|---|---|---|
| 200 | maybe, I should put iwm_nvm_channels[] somewhere in if_iwmreg.h (and use it size here directly)? | |
If you do that then it'll likely just get duplicated in each file that includes that .h file.
Just put a _MAX define somewhere, and a compile-time assert in if_iwm.c that the #define is = or larger than the set size. That'll at least fail compilation if someone ups the number of channel entries when we do 11n/11ac.
| sys/dev/iwm/if_iwm.c | ||
|---|---|---|
| 1734 | iwlwifi doesn't enforce this limitation - probably, this (and other limitations) should be set by ieee80211_regdomain(9) (not used right now (except IEEE80211_IOC_REGDOMAIN ioctl)). | |
| head/sys/dev/iwm/if_iwm.c | ||
|---|---|---|
| 175 ↗ | (On Diff #15789) | CTASSERT(9) manpage states that 'The CTASSERT() macro is deprecated and the C11 standard _Static_assert() should be used instead' - so I've replaced CTASSERT() with _Static_assert. No other changes were done. |